bahir-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ckadner <...@git.apache.org>
Subject [GitHub] bahir pull request #57: [BAHIR-128][WIP] fix failing sql-cloudant test
Date Sat, 09 Dec 2017 23:46:18 GMT
Github user ckadner commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/57#discussion_r155934979
  
    --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/common/ChangesRow.java
---
    @@ -0,0 +1,74 @@
    +/*
    + * Copyright (c) 2017 IBM Cloudant. All rights reserved.
    --- End diff --
    
    @emlaver -- is this an outdated copyright statement? If it is still valid you may need
to check with the author and/or IBM if you can contribute this code (or variations of it)
to open-source.
    
    I am surprised the RAT check did not catch this.
    
    CC @lresende


---

Mime
View raw message