Return-Path: <reviews-return-474-archive-asf-public=cust-asf.ponee.io@bahir.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id B5EDD200CC1
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 10 Jul 2017 16:52:28 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id B4639168DB9; Mon, 10 Jul 2017 14:52:28 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id F147C168D73
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 10 Jul 2017 16:52:27 +0200 (CEST)
Received: (qmail 31691 invoked by uid 500); 10 Jul 2017 14:52:27 -0000
Mailing-List: contact reviews-help@bahir.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:reviews-help@bahir.apache.org>
List-Unsubscribe: <mailto:reviews-unsubscribe@bahir.apache.org>
List-Post: <mailto:reviews@bahir.apache.org>
List-Id: <reviews.bahir.apache.org>
Reply-To: reviews@bahir.apache.org
Delivered-To: mailing list reviews@bahir.apache.org
Received: (qmail 31680 invoked by uid 99); 10 Jul 2017 14:52:26 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jul 2017 14:52:26 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id CF834DFC26; Mon, 10 Jul 2017 14:52:26 +0000 (UTC)
From: emlaver <git@git.apache.org>
To: reviews@bahir.apache.org
Reply-To: reviews@bahir.apache.org
References: <git-pr-45-bahir@git.apache.org>
In-Reply-To: <git-pr-45-bahir@git.apache.org>
Subject: [GitHub] bahir pull request #45: [WIP] [BAHIR-110] Implement _changes API for non-str...
Content-Type: text/plain
Message-Id: <20170710145226.CF834DFC26@git1-us-west.apache.org>
Date: Mon, 10 Jul 2017 14:52:26 +0000 (UTC)
archived-at: Mon, 10 Jul 2017 14:52:28 -0000

Github user emlaver commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/45#discussion_r126444627
  
    --- Diff: sql-cloudant/README.md ---
    @@ -31,15 +31,14 @@ The `--packages` argument can also be used with `bin/spark-submit`.
     
     Submit a job in Python:
         
    -    spark-submit  --master local[4] --jars <path to cloudant-spark.jar>  <path to python script> 
    +    spark-submit  --master local[4] --packages org.apache.bahir:spark-sql-cloudant_2.11:2.2.0-SNAPSHOT  <path to python script> 
    --- End diff --
    
    Good point, this should probably be something like `--packages org.apache.bahir:spark-sql-cloudant_SCALA_VERSION:PACKAGE_VERSION`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---