bahir-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mayya-sharipova <...@git.apache.org>
Subject [GitHub] bahir pull request #45: [BAHIR-110] Implement _changes API for non-streaming...
Date Fri, 21 Jul 2017 18:30:25 GMT
Github user mayya-sharipova commented on a diff in the pull request:

    https://github.com/apache/bahir/pull/45#discussion_r128830778
  
    --- Diff: sql-cloudant/src/main/scala/org/apache/bahir/cloudant/internal/ChangesReceiver.scala
---
    @@ -0,0 +1,100 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.bahir.cloudant.internal
    +
    +import org.slf4j.{Logger, LoggerFactory}
    +import play.api.libs.json.Json
    +import scalaj.http._
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.storage.StorageLevel
    +import org.apache.spark.streaming.receiver.Receiver
    +
    +import org.apache.bahir.cloudant.CloudantChangesConfig
    +import org.apache.bahir.cloudant.common._
    +
    +
    +class ChangesReceiver(config: CloudantChangesConfig)
    +  extends Receiver[String](StorageLevel.MEMORY_AND_DISK) {
    +
    +  def onStart() {
    +    // Start the thread that receives data over a connection
    +    new Thread("Cloudant Receiver") {
    +      override def run() { receive() }
    +    }.start()
    +  }
    +
    +  private def receive(): Unit = {
    +    // Get total number of docs in database using _all_docs endpoint
    +    val limit = new JsonStoreDataAccess(config)
    +      .getTotalRows(config.getTotalUrl, queryUsed = false)
    +
    +    // Get continuous _changes url
    +    val url = config.getChangesReceiverUrl.toString
    +    val selector: String = {
    +      "{\"selector\":" + config.getSelector + "}"
    +    }
    +
    +    var count = 0
    +    val clRequest: HttpRequest = config.username match {
    +      case null =>
    +        Http(url)
    +          .postData(selector)
    +          .timeout(connTimeoutMs = 1000, readTimeoutMs = 0)
    +          .header("Content-Type", "application/json")
    +          .header("User-Agent", "spark-cloudant")
    +      case _ =>
    +        Http(url)
    +          .postData(selector)
    +          .timeout(connTimeoutMs = 1000, readTimeoutMs = 0)
    +          .header("Content-Type", "application/json")
    +          .header("User-Agent", "spark-cloudant")
    +          .auth(config.username, config.password)
    +    }
    +
    +    clRequest.exec((code, headers, is) => {
    +      if (code == 200) {
    +        scala.io.Source.fromInputStream(is, "utf-8").getLines().foreach(line => {
    +          if (line.length() > 0) {
    +            val json = Json.parse(line)
    +            val jsonDoc = (json \ "doc").getOrElse(null)
    +            var doc = ""
    +            if(jsonDoc != null) {
    +              doc = Json.stringify(jsonDoc)
    +              // Verify that doc is not empty and is not deleted
    +              val deleted = (jsonDoc \ "_deleted").getOrElse(null)
    +              if(!doc.isEmpty && deleted == null) {
    +                store(doc)
    +                count += 1
    +              }
    +            }
    +          } else if (count >= limit) {
    --- End diff --
    
    should we check `(count >= limit)` before line 72 for all objects, not only empty ones?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message