bahir-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From scottkwalker <...@git.apache.org>
Subject [GitHub] bahir pull request #36: Fixes for akka example
Date Thu, 23 Feb 2017 14:23:51 GMT
GitHub user scottkwalker opened a pull request:

    https://github.com/apache/bahir/pull/36

    Fixes for akka example

    Hi, 
    I was looking at the streaming-akka example in Intellij IDE and it suggested some minor
fixes:
    - use string interpolation
    - the mutable collection must be prefixed as mutable
    
    Best regards,
    
    Scott

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/scottkwalker/bahir fixes-for-akka-example

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir/pull/36.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #36
    
----
commit bab4876857b1d732736286905b414e6ebf72f5c9
Author: Scott Walker <scott.walker@digital.hmrc.gov.uk>
Date:   2017-02-23T14:11:17Z

    Fix legacy string formatting, an interpolated string can be used instead

commit 8407773a6a56f2dc23b821266a9b065fa4008155
Author: Scott Walker <scott.walker@digital.hmrc.gov.uk>
Date:   2017-02-23T14:13:12Z

    LinkedHashSet must be prefixed

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message