bahir-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ckadner <...@git.apache.org>
Subject [GitHub] bahir pull request #34: [MINOR] fix repeated GPG passphrase prompts in relea...
Date Tue, 17 Jan 2017 09:08:14 GMT
GitHub user ckadner opened a pull request:

    https://github.com/apache/bahir/pull/34

    [MINOR] fix repeated GPG passphrase prompts in release-build.sh

    **Problem**
    
    When executing the script `dev/release-build.sh --release-prepare ...` the _Maven Release
Plugin_ repeatedly prompts for the passphrase to unlock the GPG signing key despite the exported
`GPG_PASSPHRASE` environment variable.
    
    **Reason**
    
    The _[Maven GPG Plugin](http://maven.apache.org/plugins/maven-gpg-plugin/index.html)_
accepts a `gpg.passphrase` argument like this:
    
    ```Bash
    mvn gpg:sign -Dgpg.passphrase=$GPG_PASSPHRASE
    ```
    
    However when used in combination with the _[Maven Release Plugin](http://maven.apache.org/maven-release/maven-release-plugin/prepare-mojo.html)_
then the GPG passphrase needs to be passed with the `-Darguments` property:
    
    ```
    mvn release:prepare -Darguments=-Dgpg.passphrase=$GPG_PASSPHRASE
                        ^^^^^^^^^^^^
    ```
    See http://maven.apache.org/plugins/maven-gpg-plugin/usage.html
    
    **Proposed Changes**
    
    - use the `-Darguments` property to pass on the `gpg.passphrase`
    - if the `GPG_PASSPHRASE` environment variable was not exported, prompt for it (once)
    
    ```
    $ unset GPG_PASSPHRASE
    $ dev/release-build.sh --release-prepare --releaseVersion="2.0.2"  --releaseRc="rc3" ...
    
    The environment variable GPG_PASSPHRASE is not set. Enter the passphrase to
    unlock the GPG signing key that will be used to sign the release!
    
    GPG passphrase: ◘
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ckadner/bahir GPG_passphrase_prompt

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir/pull/34.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #34
    
----
commit 08c55f45d0aeb9f2b6369a2c4146bd0b536e3baa
Author: Christian Kadner <ckadner@apache.org>
Date:   2017-01-17T08:00:50Z

    [MINOR] fix repeated GPG passphrase prompts in release-build.sh

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message