bahir-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ckadner <...@git.apache.org>
Subject [GitHub] bahir pull request #30: [MINOR] scalastyle:ImportOrderChecker - add group fo...
Date Fri, 06 Jan 2017 00:41:44 GMT
GitHub user ckadner opened a pull request:

    https://github.com/apache/bahir/pull/30

    [MINOR] scalastyle:ImportOrderChecker - add group for org.apache.bahir.*

    **Proposed change**
    
    `org.apache.bahir.*` import statements should not be mixed in group of 3rd-party imports
but instead should be grouped together in last group of imports (after group of `org.apache.spark.*`
imports which should remain a separate group)
    
    **How was this change tested?**
    
    full test build `mvn clean install test`

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ckadner/bahir scalastyle-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bahir/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit 9b8d18234197b47bff645b33598c3d986958f92a
Author: Christian Kadner <ckadner@apache.org>
Date:   2017-01-06T00:34:29Z

    [MINOR] scalastyle:ImportOrderChecker - add group for "org.apache.bahir.*" import statements

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message