bahir-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sourav-mazumder <...@git.apache.org>
Subject [GitHub] bahir issue #27: [BAHIR-75][WIP] Initital code delivery for WebHDFS data sou...
Date Wed, 16 Nov 2016 23:10:55 GMT
Github user sourav-mazumder commented on the issue:

    https://github.com/apache/bahir/pull/27
  
    Current support for .csv will cover.txt as long as records are separated by
    '\n'. The field separator can be configured. By default it is assumed to be
    ','.
    
    In future support for .json and .xml would be added.
    
    Regards,
    Sourav
    
    On Wed, Nov 16, 2016 at 3:07 PM, Christian Kadner <notifications@github.com>
    wrote:
    
    > *@ckadner* commented on this pull request.
    > ------------------------------
    >
    > In datasource-webhdfs/src/main/scala/org/apache/bahir/datasource/webhdfs/
    > DefaultSource.scala <https://github.com/apache/bahir/pull/27>:
    >
    > > +  }
    > +
    > +  /**
    > +   * Creates a new relation for data store in CSV given parameters.
    > +   * Parameters have to include 'path' and optionally 'delimiter', 'quote', and
'header'
    > +   */
    > +  override def createRelation(
    > +      sqlContext: SQLContext,
    > +      parameters: Map[String, String]): BaseRelation = {
    > +    	createRelation(sqlContext, parameters, null)
    > +  }
    > +
    > +  /**
    > +   * Creates a new relation for data store in CSV given parameters and user supported
schema.
    > +   * Parameters have to include 'path' and optionally 'delimiter', 'quote', and
'header'
    > +   */
    >
    > yup, coded for *.csv only for now ...
    >
    > @sourav-mazumder <https://github.com/sourav-mazumder> do you plan on
    > adding support for other file formats like *.txt and *.json?
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/bahir/pull/27>, or mute the thread
    > <https://github.com/notifications/unsubscribe-auth/AOQyx7ueDjp5725V0Nt0hhkX1z3x-6tUks5q-4ylgaJpZM4KzK9h>
    > .
    >



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message