Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DF412200B89 for ; Wed, 7 Sep 2016 06:18:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D9D2A160ACE; Wed, 7 Sep 2016 04:18:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 03E55160AA9 for ; Wed, 7 Sep 2016 06:18:16 +0200 (CEST) Received: (qmail 89453 invoked by uid 500); 7 Sep 2016 04:18:16 -0000 Mailing-List: contact commits-help@bahir.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@bahir.apache.org Delivered-To: mailing list commits@bahir.apache.org Received: (qmail 89441 invoked by uid 99); 7 Sep 2016 04:18:16 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Sep 2016 04:18:16 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id E49B8DFE80; Wed, 7 Sep 2016 04:18:15 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: tedyu@apache.org To: commits@bahir.apache.org Message-Id: <84fc058b4053474aa424dc16970448a1@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: bahir-flink git commit: BAHIR-59[AMQ] Fix constructor visibility and error messages (rmetzger) Date: Wed, 7 Sep 2016 04:18:15 +0000 (UTC) archived-at: Wed, 07 Sep 2016 04:18:18 -0000 Repository: bahir-flink Updated Branches: refs/heads/master 1f839d510 -> a105a7c34 BAHIR-59[AMQ] Fix constructor visibility and error messages (rmetzger) Project: http://git-wip-us.apache.org/repos/asf/bahir-flink/repo Commit: http://git-wip-us.apache.org/repos/asf/bahir-flink/commit/a105a7c3 Tree: http://git-wip-us.apache.org/repos/asf/bahir-flink/tree/a105a7c3 Diff: http://git-wip-us.apache.org/repos/asf/bahir-flink/diff/a105a7c3 Branch: refs/heads/master Commit: a105a7c3455b9851f951506ba91f1472002d323f Parents: 1f839d5 Author: tedyu Authored: Tue Sep 6 21:15:39 2016 -0700 Committer: tedyu Committed: Tue Sep 6 21:15:39 2016 -0700 ---------------------------------------------------------------------- .../streaming/connectors/activemq/AMQSinkConfig.java | 6 +++--- .../flink/streaming/connectors/activemq/AMQSource.java | 4 ++-- .../streaming/connectors/activemq/AMQSourceConfig.java | 10 +++++----- 3 files changed, 10 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/bahir-flink/blob/a105a7c3/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSinkConfig.java ---------------------------------------------------------------------- diff --git a/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSinkConfig.java b/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSinkConfig.java index 86254ff..e10c3c8 100644 --- a/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSinkConfig.java +++ b/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSinkConfig.java @@ -34,9 +34,9 @@ public class AMQSinkConfig { public AMQSinkConfig(ActiveMQConnectionFactory connectionFactory, String queueName, SerializationSchema serializationSchema, boolean persistentDelivery, DestinationType destinationType) { - this.connectionFactory = Preconditions.checkNotNull(connectionFactory, "connectionFactory"); - this.queueName = Preconditions.checkNotNull(queueName, "destinationName"); - this.serializationSchema = Preconditions.checkNotNull(serializationSchema, "serializationSchema"); + this.connectionFactory = Preconditions.checkNotNull(connectionFactory, "connectionFactory not set"); + this.queueName = Preconditions.checkNotNull(queueName, "destinationName not set"); + this.serializationSchema = Preconditions.checkNotNull(serializationSchema, "serializationSchema not set"); this.persistentDelivery = persistentDelivery; this.destinationType = Preconditions.checkNotNull(destinationType, "destinationType"); } http://git-wip-us.apache.org/repos/asf/bahir-flink/blob/a105a7c3/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java ---------------------------------------------------------------------- diff --git a/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java b/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java index 49f2cf7..e64b8fd 100644 --- a/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java +++ b/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSource.java @@ -92,7 +92,7 @@ public class AMQSource extends MessageAcknowledgingSourceBase * * @param config AMQSource configuration */ - AMQSource(AMQSourceConfig config) { + public AMQSource(AMQSourceConfig config) { super(String.class); this.connectionFactory = config.getConnectionFactory(); this.destinationName = config.getDestinationName(); @@ -218,7 +218,7 @@ public class AMQSource extends MessageAcknowledgingSourceBase Message message = consumer.receive(1000); if (! (message instanceof BytesMessage)) { - LOG.warn("Active MQ source received non bytes message: {}"); + LOG.warn("Active MQ source received non bytes message: {}", message); return; } BytesMessage bytesMessage = (BytesMessage) message; http://git-wip-us.apache.org/repos/asf/bahir-flink/blob/a105a7c3/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSourceConfig.java ---------------------------------------------------------------------- diff --git a/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSourceConfig.java b/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSourceConfig.java index 2dcb2cb..dd73b0e 100644 --- a/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSourceConfig.java +++ b/flink-connector-activemq/src/main/java/org/apache/flink/streaming/connectors/activemq/AMQSourceConfig.java @@ -37,11 +37,11 @@ public class AMQSourceConfig { AMQSourceConfig(ActiveMQConnectionFactory connectionFactory, String destinationName, DeserializationSchema deserializationSchema, RunningChecker runningChecker, DestinationType destinationType) { - this.connectionFactory = Preconditions.checkNotNull(connectionFactory, "connectionFactory"); - this.destinationName = Preconditions.checkNotNull(destinationName, "destinationName"); - this.deserializationSchema = Preconditions.checkNotNull(deserializationSchema, "deserializationSchema"); - this.runningChecker = Preconditions.checkNotNull(runningChecker, "runningChecker"); - this.destinationType = Preconditions.checkNotNull(destinationType, "destinationType"); + this.connectionFactory = Preconditions.checkNotNull(connectionFactory, "connectionFactory not set"); + this.destinationName = Preconditions.checkNotNull(destinationName, "destinationName not set"); + this.deserializationSchema = Preconditions.checkNotNull(deserializationSchema, "deserializationSchema not set"); + this.runningChecker = Preconditions.checkNotNull(runningChecker, "runningChecker not set"); + this.destinationType = Preconditions.checkNotNull(destinationType, "destinationType not set"); } public ActiveMQConnectionFactory getConnectionFactory() {