Mailing-List: contact java-dev-help@axis.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@axis.apache.org
Date: Tue, 5 Sep 2017 13:05:00 +0000 (UTC)
From: "Donald Kwakkel (JIRA)" <jira@apache.org>
To: java-dev@axis.apache.org
Message-ID: <JIRA.13099814.1504613032000.28202.1504616700758@Atlassian.JIRA>
In-Reply-To: <JIRA.13099814.1504613032000@Atlassian.JIRA>
References: <JIRA.13099814.1504613032000@Atlassian.JIRA> <JIRA.13099814.1504613032662@jira-lw-us.apache.org>
Subject: [jira] [Updated] (AXIS2-5877) XML External Entity Injections
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 05 Sep 2017 13:05:12 -0000


     [ https://issues.apache.org/jira/browse/AXIS2-5877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Kwakkel updated AXIS2-5877:
----------------------------------
    Description: 
XML parser configured in ConvertUtils.java:225 does not prevent nor limit external entities resolution. This can expose the parser to an XML External Entities attack.

Proposed fix: Enable where TransformerFactory is used always the secure processing feature:


{code:java}
	public static TransformerFactory createTransformerFactory() {
		TransformerFactory factory = TransformerFactory.newInstance();
		try {
			factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
		}
		catch (TransformerConfigurationException e) {
			throw new IllegalStateException(e);
		}
		return factory;
	}
{code}
Also found other locations where this and DocumentBuilderFactory is handled wrong. See attached screenshots.


  was:
XML parser configured in ConvertUtils.java:225 does not prevent nor limit external entities resolution. This can expose the parser to an XML External Entities attack.

Proposed fix: Enable where TransformerFactory is used always the secure processing feature:


{code:java}
	public static TransformerFactory createTransformerFactory() {
		TransformerFactory factory = TransformerFactory.newInstance();
		try {
			factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
		}
		catch (TransformerConfigurationException e) {
			throw new IllegalStateException(e);
		}
		return factory;
	}
{code}


> XML External Entity Injections
> ------------------------------
>
>                 Key: AXIS2-5877
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5877
>             Project: Axis2
>          Issue Type: Bug
>          Components: jaxws
>    Affects Versions: 1.7.6
>            Reporter: Donald Kwakkel
>            Priority: Critical
>              Labels: security
>
> XML parser configured in ConvertUtils.java:225 does not prevent nor limit external entities resolution. This can expose the parser to an XML External Entities attack.
> Proposed fix: Enable where TransformerFactory is used always the secure processing feature:
> {code:java}
> 	public static TransformerFactory createTransformerFactory() {
> 		TransformerFactory factory = TransformerFactory.newInstance();
> 		try {
> 			factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
> 		}
> 		catch (TransformerConfigurationException e) {
> 			throw new IllegalStateException(e);
> 		}
> 		return factory;
> 	}
> {code}
> Also found other locations where this and DocumentBuilderFactory is handled wrong. See attached screenshots.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org