axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AXIS2-5884) Change parameter "Description" to lower-case for service.xml.
Date Sun, 10 Sep 2017 22:16:02 GMT

    [ https://issues.apache.org/jira/browse/AXIS2-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16160490#comment-16160490
] 

Hudson commented on AXIS2-5884:
-------------------------------

SUCCESS: Integrated in Jenkins build Axis2 #3829 (See [https://builds.apache.org/job/Axis2/3829/])
AXIS2-5884: Allow both 'description' and 'Description' in service.xml and module.xml files.
(veithen: rev 1807970)
* (edit) axis2/modules/kernel/src/org/apache/axis2/deployment/DeploymentConstants.java
* (edit) axis2/modules/kernel/src/org/apache/axis2/deployment/ModuleBuilder.java
* (edit) axis2/modules/kernel/src/org/apache/axis2/deployment/ServiceBuilder.java
* (edit) axis2/modules/samples/json/src/META-INF/services.xml
* (edit) axis2/src/site/xdoc/docs/axis2config.xml
* (edit) axis2/systests/webapp-tests/src/test/java/org/apache/axis2/webapp/AxisAdminServletITCase.java
* (edit) axis2/systests/webapp-tests/src/test/java/org/apache/axis2/webapp/AxisServletITCase.java


> Change parameter "Description" to lower-case for service.xml.
> -------------------------------------------------------------
>
>                 Key: AXIS2-5884
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5884
>             Project: Axis2
>          Issue Type: Improvement
>          Components: deployment
>    Affects Versions: 1.7.6
>            Reporter: Thorsten Schöning
>            Priority: Minor
>
> Because of AXIS2-5881 I had a look at my own Axis2 services and recognized that their
description is wrong and is the service name instead of what is defined in the service.xml
file. The problem was simply using "description" instead of "Description" and the latter is
documented, so I must have simply overlooked the different spelling.
> http://axis.apache.org/axis2/java/core/docs/axis2config.html#Service_Configuration
> So why not change this configuration to lower case to be in-line with all other configs
in this file and with most other configs as well?
> Searching through the Axis2 codebase reveals that "description" is hard coded at some
places already and I even found service.xml files in tests where "description" is used, so
are wrong in theory. The only environment where "Description" seems to make sense is module.xml,
which uses "InFlow", "OutFlow" etc. as well.
> So we can change the value of TAG_DESCRIPTION to be lower case and hard-code something
for modules or keep TAG_DESCRIPTION as it is and hard code a lower case variant for service.xml
or simply use "description" for all, which wouldn't like that right in module.xml anymore...
> What do you prefer?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


Mime
View raw message