axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Schöning (JIRA) <j...@apache.org>
Subject [jira] [Commented] (AXIS2-5873) "Apache Axis2 - Distribution" doesn't build on Windows
Date Tue, 29 Aug 2017 10:51:00 GMT

    [ https://issues.apache.org/jira/browse/AXIS2-5873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145101#comment-16145101
] 

Thorsten Schöning commented on AXIS2-5873:
------------------------------------------

Just for reference, because I came across that question right now: Using "%url%" shouldn't
be a problem for paths with spaces as the underluying value is properly generated using File.toURI().
Don't know how to test that, though, because the path in this concrete pom.xml resolves to
my local Maven repo and that doesn't contain any spaces.

{CODE}
return getArtifactFile(artifact).toURI().toURL().toString();
{CODE}

https://github.com/veithen/alta/blob/master/src/main/java/com/github/veithen/alta/AbstractGenerateMojo.java#L107

> "Apache Axis2 - Distribution" doesn't build on Windows
> ------------------------------------------------------
>
>                 Key: AXIS2-5873
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5873
>             Project: Axis2
>          Issue Type: Bug
>          Components: modules
>    Affects Versions: 1.8.0
>         Environment: Windows 10 Pro x86-64, JDK 1.8 x86-64
>            Reporter: Thorsten Schöning
>         Attachments: support Windows paths for distribution.patch
>
>
> "distribution/pom.xml" contains embedded Groovy and uses Maven build properties to access
some paths, which resolve to some string using "\" on Windows. The problem is that these strings
contain only one "\", which is valid in XML, but are forwarded to Groovy code, where those
strings become invalid.
> {CODE}
> [INFO] --- gmavenplus-plugin:1.5:execute (check-webapp-content) @ distribution ---
> [DEBUG] Configuring mojo org.codehaus.gmavenplus:gmavenplus-plugin:1.5:execute from plugin
realm ClassRealm[plugin>org.codehaus.gmavenplus:gmavenplus-plugin:1.5, parent: sun.misc.Launcher$AppClassLoader@5c647e05]
> [DEBUG] Configuring mojo 'org.codehaus.gmavenplus:gmavenplus-plugin:1.5:execute' with
include-project-test-dependencies configurator -->
> [DEBUG]   (f) allowSystemExits = false
> [DEBUG]   (f) bindPropertiesToSeparateVariables = true
> [DEBUG]   (f) continueExecuting = false
> [DEBUG]   (f) mojoExecution = org.codehaus.gmavenplus:gmavenplus-plugin:1.5:execute {execution:
check-webapp-content}
> [DEBUG]   (f) pluginArtifacts = [...]
> [DEBUG]   (f) project = MavenProject: org.apache.axis2:distribution:1.8.0-SNAPSHOT @
C:\Users\tschoening\Documents\Eclipse\Java Axis2\axis2\modules\distribution\pom.xml
> [DEBUG]   (f) scripts = [import java.util.jar.*
>                                     def jar = new JarInputStream(new FileInputStream("C:\Users\tschoening\.m2\repository\org\apache\axis2\axis2-webapp\1.8.0-SNAPSHOT\axis2-webapp-1.8.0-SNAPSHOT.war"))
>                                     def expected = new HashSet()
>                                     def entry
>                                     while(entry = jar.nextJarEntry) {
>                                         expected.add(entry.name)
>                                     }
>                                     jar.close()
>                                     jar = new JarInputStream(new FileInputStream("C:\Users\tschoening\Documents\Eclipse\Java
Axis2\axis2\modules\distribution\target/axis2-1.8.0-SNAPSHOT/dist/axis2.war"))
>                                     while(entry = jar.nextJarEntry) {
>                                         if (!expected.remove(entry.name)) {
>                                             throw new Error("Unexpected entry in Web
app: " + entry.name)
>                                         }
>                                     }
>                                     if (!expected.empty) {
>                                         throw new Error("Missing entries in Web app:
" + expected)
>                                     }
>                                     jar.close()]
> [DEBUG]   (f) session = org.apache.maven.execution.MavenSession@3d904e9c
> [DEBUG]   (f) skipTests = false
> [DEBUG]   (f) sourceEncoding = UTF-8
> [DEBUG] -- end configuration --
> [INFO] Using Groovy 2.4.4 to perform execute.
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Axis2 - Distribution ........................ FAILURE [ 49.237 s]
> [INFO] Samples parent POM ................................. SKIPPED
> [INFO] JAXWS - Starting from Java Example ................. SKIPPED
> [INFO] JAXWS Addressbook Service .......................... SKIPPED
> [INFO] JAXWS Calculator Service ........................... SKIPPED
> [INFO] JAXWS Interop Sample ............................... SKIPPED
> [INFO] JAXWS Samples - Echo, Ping, MTOM ................... SKIPPED
> [INFO] Apache Axis2 -JAXWS Version Service ................ SKIPPED
> [INFO] Apache Axis2 Transport-HTTPS sample ................ SKIPPED
> [INFO] httpsService ....................................... SKIPPED
> [INFO] httpsClient ........................................ SKIPPED
> [INFO] Apache Axis2 Transport-JMS sample .................. SKIPPED
> [INFO] jmsService ......................................... SKIPPED
> [INFO] databinding-tests .................................. SKIPPED
> [INFO] jaxbri-tests ....................................... SKIPPED
> [INFO] echo ............................................... SKIPPED
> [INFO] webapp-tests ....................................... SKIPPED
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 51.245 s
> [INFO] Finished at: 2017-08-28T19:27:47+02:00
> [INFO] Final Memory: 60M/459M
> [INFO] ------------------------------------------------------------------------
> [ERROR] Failed to execute goal org.codehaus.gmavenplus:gmavenplus-plugin:1.5:execute
(check-webapp-content) on project distribution: Error occurred while calling a method on a
Groovy class from classpath. InvocationTargetException: startup failed:
> [ERROR] Script1.groovy: 3: unexpected char: '\' @ line 3, column 89.
> [ERROR] Stream(new FileInputStream("C:\Users\tsc
> [ERROR] ^
> [ERROR]
> [ERROR] 1 error
> [ERROR] -> [Help 1]
> {CODE}
> The attached patch fixes the problem by using "%url%" instead of "%file%", because that
can be converted to a path at runtime easily. Please note that while the value is named "%url%",
I'm not creating an instance of the "URL" class in Java to parse that string, but using "URI"
instead directly, because that's what's needed by the "File" CTOR anyway in the end. You might
consider that unclean, I think the difference is academic and it works as is for me. So feel
free to change it as necessary.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


Mime
View raw message