Return-Path: X-Original-To: apmail-axis-java-dev-archive@www.apache.org Delivered-To: apmail-axis-java-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 61BD318C87 for ; Sun, 24 Jan 2016 16:12:40 +0000 (UTC) Received: (qmail 28207 invoked by uid 500); 24 Jan 2016 16:12:40 -0000 Delivered-To: apmail-axis-java-dev-archive@axis.apache.org Received: (qmail 28058 invoked by uid 500); 24 Jan 2016 16:12:40 -0000 Mailing-List: contact java-dev-help@axis.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@axis.apache.org Delivered-To: mailing list java-dev@axis.apache.org Received: (qmail 28049 invoked by uid 99); 24 Jan 2016 16:12:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Jan 2016 16:12:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D5C562C1F57 for ; Sun, 24 Jan 2016 16:12:39 +0000 (UTC) Date: Sun, 24 Jan 2016 16:12:39 +0000 (UTC) From: "Andreas Veithen (JIRA)" To: java-dev@axis.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (AXIS2-4570) Remove optimizeContent objects and arguments from ADB-generated stubs? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AXIS2-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Veithen updated AXIS2-4570: ----------------------------------- Fix Version/s: (was: 1.7.1) 1.8.0 > Remove optimizeContent objects and arguments from ADB-generated stubs? > ---------------------------------------------------------------------- > > Key: AXIS2-4570 > URL: https://issues.apache.org/jira/browse/AXIS2-4570 > Project: Axis2 > Issue Type: Improvement > Components: adb > Affects Versions: 1.5.1 > Reporter: Glen Mazza > Priority: Minor > Fix For: 1.8.0 > > > Axis2 1.4.1 and 1.5.1 (and probably all older versions) are providing an opNameArray object and optimizeContent method that serve no purpose within the ADB-generated stubs: > private javax.xml.namespace.QName[] opNameArray = null; > private boolean optimizeContent(javax.xml.namespace.QName opName) { // *always* returns false > if (opNameArray == null) { > return false; > } > for (int i = 0; i < opNameArray.length; i++) { > if (opName.equals(opNameArray[i])) { > return true; > } > } > return false; > } > Also, the toOM() and toEnvelope() methods generated in the stubs take an optimizeContent argument that both method implementations ignore. Further, all callers to those methods just call the above optimizeContent() method, which invariably returns false. > These methods are adding unnecessarily to processing overhead and make the generated code more confusing. To simplify things it would be good if you could remove the optimizeContent() method above, the opNameArray object, and the optimizeContent boolean arguments from the generated toOM() and toEnvelope() methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org For additional commands, e-mail: java-dev-help@axis.apache.org