axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AXIS2-5672) Addressing Action attributes are parsed incorrectly when deploying service from WSDL
Date Thu, 02 Jul 2015 03:38:04 GMT

    [ https://issues.apache.org/jira/browse/AXIS2-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611414#comment-14611414
] 

Hudson commented on AXIS2-5672:
-------------------------------

SUCCESS: Integrated in Axis2 #2892 (See [https://builds.apache.org/job/Axis2/2892/])
applying pacth for AXIS2-5672 (deepal: rev 1688758)
* /axis/axis2/java/core/trunk/modules/codegen/src/org/apache/axis2/wsdl/codegen/CodeGenerationEngine.java
* /axis/axis2/java/core/trunk/modules/codegen/test-resources/schemas/custom_schemas/generated.xsd
* /axis/axis2/java/core/trunk/modules/integration/test/org/apache/axis2/wsdl
* /axis/axis2/java/core/trunk/modules/integration/test/org/apache/axis2/wsdl/ExtensionTypesTest.java
* /axis/axis2/java/core/trunk/modules/java2wsdl/test/org/apache/axis2/description/Java2WSDLTest.java
* /axis/axis2/java/core/trunk/modules/jaxws/test/org/apache/axis2/jaxws/description/DescriptionTestUtils2.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/description/AxisService.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/description/WSDL11ToAxisServiceBuilder.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/wsdl/WSDLUtil.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/wsdl/util/WSDLWrapperReloadImpl.java
* /axis/axis2/java/core/trunk/modules/kernel/test-resources/wsdl/Version.wsdl
* /axis/axis2/java/core/trunk/modules/kernel/test-resources/wsdl/actionTests.wsdl
* /axis/axis2/java/core/trunk/modules/kernel/test-resources/wsdl/printWSDLreference.wsdl
* /axis/axis2/java/core/trunk/modules/kernel/test-resources/wsdl/testGenerateInterfaceOperationElement11_WSDL.wsdl
* /axis/axis2/java/core/trunk/modules/kernel/test-resources/wsdl/testGenerateInterfaceOperationElement_WSDL.wsdl
* /axis/axis2/java/core/trunk/modules/kernel/test/org/apache/axis2/addressing/wsdl/WSDL11ActionHelperTest.java
* /axis/axis2/java/core/trunk/modules/kernel/test/org/apache/axis2/description/WSDL11ToAxisServiceBuilderTest.java
* /axis/axis2/java/core/trunk/modules/kernel/test/org/apache/axis2/description/WSDLWrapperTest.java
* /axis/axis2/java/core/trunk/modules/kernel/test/org/apache/axis2/wsdl
* /axis/axis2/java/core/trunk/modules/kernel/test/org/apache/axis2/wsdl/WSDLUtilTest.java
* /axis/axis2/java/core/trunk/modules/metadata/src/org/apache/axis2/jaxws/description/builder/JAXWSRIWSDLGenerator.java
* /axis/axis2/java/core/trunk/modules/metadata/src/org/apache/axis2/jaxws/util/WSDL4JWrapper.java
* /axis/axis2/java/core/trunk/modules/metadata/src/org/apache/axis2/jaxws/wsdl/WSDLReaderConfiguratorImpl.java
* /axis/axis2/java/core/trunk/modules/metadata/test/org/apache/axis2/jaxws/description/DescriptionTestUtils.java
* /axis/axis2/java/core/trunk/modules/metadata/test/org/apache/axis2/metadata/registry/MetadataFactoryRegistryTests.java
* /axis/axis2/java/core/trunk/modules/tool/axis2-eclipse-codegen-plugin/src/main/java/org/apache/axis2/tool/codegen/eclipse/util/WSDLPropertyReader.java
* /axis/axis2/java/core/trunk/modules/tool/axis2-idea-plugin/src/main/java/org/apache/axis2/tools/bean/CodegenBean.java
* /axis/axis2/java/core/trunk/modules/tool/axis2-idea-plugin/src/main/java/org/apache/ideaplugin/frames/WSDLFileSelectionPage.java


> Addressing Action attributes are parsed incorrectly when deploying service from WSDL
> ------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5672
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5672
>             Project: Axis2
>          Issue Type: Bug
>          Components: Addressing, kernel
>    Affects Versions: 1.6.2
>            Reporter: Detelin Yordanov
>             Fix For: nightly
>
>         Attachments: axis2_patch.txt, axis2_patch.txt
>
>
> When creating a web service out of a WSDL which contains WS-Addressing Action attributes
with format <prefix>:<value>, Axis2 will strip the "<prefix>:" part if the
WSDL document contains a namespace declaration for <prefix> on some of the parent elements.
For example, if the definition element contains the following namespace declaration:
> xmlns:http="http://schemas.xmlsoap.org/wsdl/http/"
> And operation's input contains a wsaw:Action that starts with "http:":
> <wsdl:input message="ns:getVersionRequest" wsam:Action="http://axisversion.sample/VersionPortType/getVersionWSAMRequest"/>
> Then the result would be that the input AxisMessage is configured with an incorrect Action
value of "//axisversion.sample/VersionPortType/getVersionWSAMRequest".
> I'm attaching a patch that contains a test case to verify this behavior - please see
WSDL11ToAxisServiceBuilderTest.testGetVersionActions() method.
> I investigated the issue and I think this is caused by WSDL4J assuming wsaw:Action attribute's
value is of QName type and thus tries to parse it as such, expecting that it might have a
namespace prefix. I think this is wrong and WSDL4J has to be configured to process wsaw:Action
values as simple literals rather than QNames. I have added a utility method for that, see:
> WSDLUtil.registerDefaultExtensionAttributeTypes
> This will register all WS-Addressing Action attribute flavors (for each known namespace)
in WSDL ExtensionRegistry to be of String type. For this to work, the so configured ExtensionRegistry
must be used whenever a WSDLReader is created, therefore I added an additional utility method
to be used for creating WSDLReader instances:
> WSDLUtil.newWSDLReaderWithPopulatedExtensionRegistry
> I have replaced the regular WSDLFactory.newWSDLReader calls throughout Axis2 codebase
with this new factory method.
> While doing this, I noticed that in the past this issue might have been identified and
fixed in Axis2 CodeGenerationEngine alone:
> https://svn.apache.org/viewvc?view=revision&revision=1003032
> The attached patch is basically similar, but it would fix all other places in Axis2 code
where WSDLReader instance is created.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


Mime
View raw message