axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shameera Rathnayaka (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (AXIS2-5511) Missing close call on FileInputStream
Date Fri, 19 Apr 2013 08:39:16 GMT

    [ https://issues.apache.org/jira/browse/AXIS2-5511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13636186#comment-13636186
] 

Shameera Rathnayaka commented on AXIS2-5511:
--------------------------------------------

Hi Erik,

This has fixed in trunk, Instead of above line of code trunk has this, 
           FileInputStream fin = new FileInputStream(file);
            byteArray = IOUtils.toByteArray(fin);
            fin.close();

Thanks,
Shameera.

                
> Missing close call on FileInputStream
> -------------------------------------
>
>                 Key: AXIS2-5511
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5511
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Erik Vikström
>            Priority: Trivial
>         Attachments: streamClose.patch
>
>
> The "prettify(File)" method within "org.apache.axis2.util.XMLPrettyPrinter" creates a
FileInputStream but does not close it explicitly. Hence XML files are locked for a while after
this feature is being used; the stream is closed implicitly when the FileInputStream instance
is garbage collected, but you never now when in time this happens.
> Since this class is used when running the code-generator, which we are using frequently
within our application, this results in that we cannot tidy up files after this task has completed.
> Current workaround for us was to implement a custom Emitter and avoid running the XML
pretty printing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


Mime
View raw message