Mailing-List: contact java-dev-help@axis.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@axis.apache.org
Date: Wed, 9 May 2012 12:37:48 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: java-dev@axis.apache.org
Message-ID: 
 <1654293999.44023.1336567069011.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1970813897.38099.1336467736130.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (AXIS2-5314) loadServicesFromUrl(URL repoURL)
 and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are
 outdated.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/AXIS2-5314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271363#comment-13271363 ] 

Hudson commented on AXIS2-5314:
-------------------------------

Integrated in Axis2 #1444 (See [https://builds.apache.org/job/Axis2/1444/])
    AXIS2-5314 - Since Axis2 transport use these methods it is not possible to remove them but I cleaned those methods as follows.
* Move actual Service/Module build code into corresponding Deployers. Now above methods only mark artifacts for deployment, within the particular Deployer it distinguish file based deployable artifacts and URL based employables and act upon. 
* Documented use cases of URL based deployment.
* Cleaned codes and remove Java5 warring.  

I have tested with JAR file and a HTTP based repository. (Revision 1336090)

     Result = SUCCESS
sagara : 
Files : 
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/DeploymentEngine.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/ModuleDeployer.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/RepositoryListener.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/ServiceDeployer.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/WarBasedAxisConfigurator.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/repository/util/DeploymentFileData.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/deployment/repository/util/WSInfoList.java
* /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/util/FaultyServiceData.java

                
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. 
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-5314
>                 URL: https://issues.apache.org/jira/browse/AXIS2-5314
>             Project: Axis2
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.6.2
>            Reporter: Sagara Gunathunga 
>            Assignee: Sagara Gunathunga 
>             Fix For: 1.7.0
>
>
> loadServicesFromUrl(URL repoURL) and loadRepositoryFromURL(URL repoURL) methods on DeploymentEngine are outdated. I found following issues.
> 1.) Above two methods try to deploy modules/services based on files called services.list and modules.list without depend on repository. AFAIK these concepts were used very beginning and haven't maintain for many years.
> 2.) These two methods do not respect to deployment features such as hot deployment, hot update etc.
> 3.) Above methods do not compatible with other deployment approaches and completely ignore Axis2 Deployer architecture. In fact, above method populate Axis2 modules and service within method body themselves instead of calling corresponding Deployer.   
> 4.) Above methods do not care/related to repository scheduler job.
> Also I haven't notice any hint that someone use these methods for last few years. I don't see much advantage promoting another deployment approach ( i. e based on services.list and modules.list) again that we haven't maintain for many years.  Hence I suggest to remove these methods in future releases. For next release let's keep these methods but sync method bodies with current deployment architecture. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org