Mailing-List: contact java-dev-help@axis.apache.org; run by ezmlm
Precedence: bulk
Reply-To: java-dev@axis.apache.org
Received-SPF: pass (nike.apache.org: domain of sagara.gunathunga@gmail.com
 designates 209.85.216.180 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CADx4_uWTSgFYfEiR50G6gRshnR0GXn=uty2cZCjWSp5VRFstgg@mail.gmail.com>
References: <20110927084505.A8A25238897D@eris.apache.org>
 <CADx4_uWTSgFYfEiR50G6gRshnR0GXn=uty2cZCjWSp5VRFstgg@mail.gmail.com>
From: Sagara Gunathunga <sagara.gunathunga@gmail.com>
Date: Thu, 29 Sep 2011 16:52:54 +0530
Message-ID: 
 <CANzUfzdFKGHGr3XeHpARSDY1fLgHC9AactghpsstdRcX4QW5Yg@mail.gmail.com>
Subject: Re: svn commit: r1176281 -
 /axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/description/java2wsdl/TypeTable.java
To: java-dev@axis.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 29, 2011 at 12:54 AM, Andreas Veithen
<andreas.veithen@gmail.com> wrote:
> That doesn't look like good OO design. XMLGregorianCalendar is an
> abstract API and the actual runtime type is completely implementation
> dependent. Trying to enumerate every possible existing implementation
> is obviously not a correct approach. I would not be surprised if e.g.
> on IBM WebSphere, that API is implemented by yet another class.

Agree on you, in fact my original aim was to use instanceof operator
to identify implementation class. BTW I have changed above method in
r1177265.

Thanks !

>
> This probably points to a design flaw in the TypeTable thing.
>
> Andreas
>
> On Tue, Sep 27, 2011 at 10:45, =A0<sagara@apache.org> wrote:
>> Author: sagara
>> Date: Tue Sep 27 08:45:05 2011
>> New Revision: 1176281
>>
>> URL: http://svn.apache.org/viewvc?rev=3D1176281&view=3Drev
>> Log:
>> Since org.apache.xerces.jaxp.datatype.XMLGregorianCalendarImpl is not an=
 instantiable class this method return null, changed to use Class names.
>>
>> Modified:
>> =A0 =A0axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/de=
scription/java2wsdl/TypeTable.java
>>
>> Modified: axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2=
/description/java2wsdl/TypeTable.java
>> URL: http://svn.apache.org/viewvc/axis/axis2/java/core/trunk/modules/ker=
nel/src/org/apache/axis2/description/java2wsdl/TypeTable.java?rev=3D1176281=
&r1=3D1176280&r2=3D1176281&view=3Ddiff
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
>> --- axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/descr=
iption/java2wsdl/TypeTable.java (original)
>> +++ axis/axis2/java/core/trunk/modules/kernel/src/org/apache/axis2/descr=
iption/java2wsdl/TypeTable.java Tue Sep 27 08:45:05 2011
>> @@ -330,25 +330,18 @@ public class TypeTable {
>> =A0 =A0 =A0* =A0 =A0 =A0 =A0 =A0 =A0the name
>> =A0 =A0 =A0* @return the schema type name by class
>> =A0 =A0 =A0*/
>> - =A0 =A0private QName getSchemaTypeNameByClass(String name) {
>> - =A0 =A0 =A0 =A0Object dataClass;
>> - =A0 =A0 =A0 =A0try {
>> - =A0 =A0 =A0 =A0 =A0 =A0dataClass =3D Class.forName(name).newInstance()=
;
>> - =A0 =A0 =A0 =A0 =A0 =A0/*
>> - =A0 =A0 =A0 =A0 =A0 =A0 * XMLGregorianCalendar can be found as followi=
ng classes.
>> - =A0 =A0 =A0 =A0 =A0 =A0 * 1.)com.sun.org.apache.xerces.internal.jaxp.d=
atatype.XMLGregorianCalendarImpl
>> - =A0 =A0 =A0 =A0 =A0 =A0 * 2.)org.apache.xerces.jaxp.datatype.XMLGregor=
ianCalendarImpl
>> - =A0 =A0 =A0 =A0 =A0 =A0 */
>> - =A0 =A0 =A0 =A0 =A0 =A0if (dataClass instanceof XMLGregorianCalendar) =
{
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return (QName) simpleTypetoxsd.get(XMLG=
regorianCalendar.class
>> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.getName());
>> - =A0 =A0 =A0 =A0 =A0 =A0}
>> - =A0 =A0 =A0 =A0} catch (InstantiationException e) {
>> - =A0 =A0 =A0 =A0 =A0 =A0e.printStackTrace();
>> - =A0 =A0 =A0 =A0} catch (IllegalAccessException e) {
>> - =A0 =A0 =A0 =A0 =A0 =A0e.printStackTrace();
>> - =A0 =A0 =A0 =A0} catch (ClassNotFoundException e) {
>> - =A0 =A0 =A0 =A0 =A0 =A0e.printStackTrace();
>> + =A0 =A0private QName getSchemaTypeNameByClass(String name) {
>> + =A0 =A0 =A0 =A0/*
>> + =A0 =A0 =A0 =A0 * XMLGregorianCalendar can be found as following class=
es.
>> + =A0 =A0 =A0 =A0 * 1.)com.sun.org.apache.xerces.internal.jaxp.datatype.=
XMLGregorianCalendarImpl
>> + =A0 =A0 =A0 =A0 * 2.)org.apache.xerces.jaxp.datatype.XMLGregorianCalen=
darImpl
>> + =A0 =A0 =A0 =A0 */
>> + =A0 =A0 =A0 =A0if ("com.sun.org.apache.xerces.internal.jaxp.datatype.X=
MLGregorianCalendarImpl"
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.equals(name)
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0|| "org.apache.xerces.jaxp.datatype.XML=
GregorianCalendarImpl"
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.equals(name)) {
>> + =A0 =A0 =A0 =A0 =A0 =A0return (QName) simpleTypetoxsd.get(XMLGregorian=
Calendar.class
>> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0.getName());
>> =A0 =A0 =A0 =A0 }
>> =A0 =A0 =A0 =A0 return null;
>> =A0 =A0 }
>>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
> For additional commands, e-mail: java-dev-help@axis.apache.org
>
>


--=20
Sagara Gunathunga

Blog =A0 =A0 =A0- http://ssagara.blogspot.com
Web =A0 =A0 =A0- http://people.apache.org/~sagara/
LinkedIn - http://www.linkedin.com/in/ssagara

---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org