Return-Path: Delivered-To: apmail-axis-java-dev-archive@www.apache.org Received: (qmail 80106 invoked from network); 19 Dec 2010 11:43:26 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 19 Dec 2010 11:43:26 -0000 Received: (qmail 47239 invoked by uid 500); 19 Dec 2010 11:43:25 -0000 Delivered-To: apmail-axis-java-dev-archive@axis.apache.org Received: (qmail 46984 invoked by uid 500); 19 Dec 2010 11:43:24 -0000 Mailing-List: contact java-dev-help@axis.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: java-dev@axis.apache.org Delivered-To: mailing list java-dev@axis.apache.org Received: (qmail 46971 invoked by uid 99); 19 Dec 2010 11:43:24 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Dec 2010 11:43:24 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.22] (HELO thor.apache.org) (140.211.11.22) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 19 Dec 2010 11:43:24 +0000 Received: from thor (localhost [127.0.0.1]) by thor.apache.org (8.13.8+Sun/8.13.8) with ESMTP id oBJBh4rm001201 for ; Sun, 19 Dec 2010 11:43:04 GMT Message-ID: <11792058.202161292758984060.JavaMail.jira@thor> Date: Sun, 19 Dec 2010 06:43:04 -0500 (EST) From: "Samisa Abeysinghe (JIRA)" To: java-dev@axis.apache.org Subject: [jira] Updated: (AXIS2-4570) Remove optimizeContent objects and arguments from ADB-generated stubs? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/AXIS2-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Samisa Abeysinghe updated AXIS2-4570: ------------------------------------- Fix Version/s: (was: 1.5.1) 1.6 > Remove optimizeContent objects and arguments from ADB-generated stubs? > ---------------------------------------------------------------------- > > Key: AXIS2-4570 > URL: https://issues.apache.org/jira/browse/AXIS2-4570 > Project: Axis2 > Issue Type: Improvement > Components: adb > Affects Versions: 1.5.1 > Reporter: Glen Mazza > Priority: Minor > Fix For: 1.6 > > > Axis2 1.4.1 and 1.5.1 (and probably all older versions) are providing an opNameArray object and optimizeContent method that serve no purpose within the ADB-generated stubs: > private javax.xml.namespace.QName[] opNameArray = null; > private boolean optimizeContent(javax.xml.namespace.QName opName) { // *always* returns false > if (opNameArray == null) { > return false; > } > for (int i = 0; i < opNameArray.length; i++) { > if (opName.equals(opNameArray[i])) { > return true; > } > } > return false; > } > Also, the toOM() and toEnvelope() methods generated in the stubs take an optimizeContent argument that both method implementations ignore. Further, all callers to those methods just call the above optimizeContent() method, which invariably returns false. > These methods are adding unnecessarily to processing overhead and make the generated code more confusing. To simplify things it would be good if you could remove the optimizeContent() method above, the opNameArray object, and the optimizeContent boolean arguments from the generated toOM() and toEnvelope() methods. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org For additional commands, e-mail: java-dev-help@axis.apache.org