axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Armstrong (JIRA)" <j...@apache.org>
Subject [jira] Created: (AXIS2-4880) I have patches to fix poor scalability of ADB's POJO XMLStreamReader implementation
Date Mon, 15 Nov 2010 11:02:13 GMT
I have patches to fix poor scalability of ADB's POJO XMLStreamReader implementation
-----------------------------------------------------------------------------------

                 Key: AXIS2-4880
                 URL: https://issues.apache.org/jira/browse/AXIS2-4880
             Project: Axis2
          Issue Type: Improvement
          Components: adb
    Affects Versions: 1.5.2
         Environment: Debian Lenny (x86_64), Java 1.6.0 (Sun), NetBeans, Tomcat 6, POJO web
service deployed as .aar file.
            Reporter: Dan Armstrong


First, ADB's XMLStreamReader implementation becomes much slower when many complex types exist
in the TypeTable.  This causes many repeated interations through the entire map for building
the ADBNamespaceContext.  I have removed the necessity of this repeated iteration by:
  1) TypeTable generates prefixes when new QName is added
  2) TypeTable maintains prefix->namespace and namespace->prefix mappings
  3) ADBNamespaceContext now checks in this order (should be functionally equivalent to adding
all complex types from TypeTable, but without the overhead):
    a) Use any added directly to our context
    b) Check TypeTable mappings (This is the key addition)
    c) Check parent NamespaceContext

Second, ADBNamespaceContext is fairly heavy weight in heap space.  I have minimized the heap
space by:
  1) Delayed allocation of the internal ArraySet
  2) Using alternate AddOneNamespaceContext when only one QName is added to the NamespaceContext.

In our system we currently have 407 complex types in the TypeTable and were suffering serious
slowdown.  We have more types to add to this system so this problem needed to be addressed.
 The results of my patches to ADB in Axis 1.5.2 are:

    Before modifications:
        751.554: Warm-up
        752.395: Second pass

    After modifications:
        138.107: Warm-up
        110.705: Second pass

    RMI (Just for comparison):
        16.818: Warm-up
        14.059: Second pass

In conclusion, the new code is seven times as fast for our scenario with a higher number of
complex types.  Where may I send the patches or may I commit direction to your repositories?


Thank you,

Dan Armstrong
AO Industries, Inc.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscribe@axis.apache.org
For additional commands, e-mail: java-dev-help@axis.apache.org


Mime
View raw message