axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rich Scheuerle (JIRA)" <>
Subject [jira] Commented: (AXIS2-4733) Incorrect content-type used in serialized SOAP message for an XML document attachment
Date Tue, 08 Jun 2010 02:04:12 GMT


Rich Scheuerle commented on AXIS2-4733:

Hi Phil,

I inspected the patch,  and I understand the need for a WrappedDataHandler.

However, you also need to change the Axis2 SAAJ implementation (org.apache.axis2.saaj.AttachmentPartImpl)
to override the setContentType method and use the WrappedDataHandler.

This means that the WrappedDataHandler (and tests) will need to be moved to a different package
and module that is accessible from the Axis2 SAAJ module.

I suggest that it should be moved to the kemel module and the org.apache.axis2.util package
since this is a common utility.
We also need an Axis2 SAAJ test to make sure Axis2 SAAJ AttachmentPart behaves correctly.

Comments ?

Rich Scheuerle

> Incorrect content-type used in serialized SOAP message for an XML document attachment
> -------------------------------------------------------------------------------------
>                 Key: AXIS2-4733
>                 URL:
>             Project: Axis2
>          Issue Type: Bug
>          Components: jaxws
>    Affects Versions: nightly
>            Reporter: Phil Adams
>            Assignee: Rich Scheuerle
>         Attachments: patch.txt
> When using the SAAJ API, a user could add an AttachmentPart to the SOAPMessage and explicitly
set the content type of the attachment by calling AttachmentPart.setContentType().   This
causes the AttachmentPart to maintain the user-specified content type separate from the content
type of the underlying DataHandler.    Within the jaxws module, the DataHandler instance is
saved away and then used to serialize the SOAP message, but we don't maintain the user-specified
content type.  Consequently, the DataHandler's content type is then used unconditionally when
serializing the MIME part in the output message.     Recently, the DataHandler class (or more
likely one of its underlying DataSource implementations) has started using a default content
type of "application/xml" for an XML document attachment.   This has caused a failure in a
Java EE CTS testcase, as the testcase explicitly sets the content type of the AttachmentPart
to "text/xml" and expects that to be used in the outgoing request message.   I'm including
a patch which fixes this problem by introducing a new "WrappedDataHandler" class which maintains
the content type from the AttachmentPart as well as the DataHandler instance.   This allows
for the correct content type to be used when serializing the message...

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message