axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ruwan Linton (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AXIS2-4552) TransportListener#init called twice on the same instance
Date Sat, 14 Nov 2009 12:40:39 GMT

    [ https://issues.apache.org/jira/browse/AXIS2-4552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777907#action_12777907
] 

Ruwan Linton commented on AXIS2-4552:
-------------------------------------

If you carefully look at the current ListenerManager implementation, only possibility that
this could occur is if some one tries to add an already started transport to the listener
manager without letting the listener manager know that it is started. Well, it could be that
the listener is manually initialized but not started, and some code should be trying to add
that particular listener to the listener manager.

If that is the case I would say that is a wrong usage of the listener manager API, I agree
we need a bit of API documentation to the listener manager here. I will try to add that soon.
So the solution is if you take control of the initialization of the listener you should also
take the responsibility of starting it before adding to the listener manager and you should
inform that this particular listener has been already started to the listener manager.

I will search for such usages of the listener manager, but if you know of a place where we
do this please point me so that you can save a bit of my time.

With the above explanation I don't see any issues with the patch that I have provided nor
the current listener manager implementation except for some missing API documentation.

> TransportListener#init called twice on the same instance
> --------------------------------------------------------
>
>                 Key: AXIS2-4552
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4552
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: nightly
>            Reporter: Andreas Veithen
>             Fix For: 1.6
>
>
> It seems that under some circumstances, the init method of the same TransportListener
instance is called twice during the lifecycle of the listener. Evidence can be found here:
> http://markmail.org/thread/25ksz5k2pnunxkpd
> http://svn.apache.org/viewvc?rev=835750&view=rev
> This is of course incorrect: the init method must be called only once on a given instance.
This is probably a regression caused by Ruwan's patch (or Glen's corrections to that patch)
for AXIS2-4304 [Note: if this is the case then probably Axis2 1.5 is also affected]. This
is a major issue since it causes uncontrollable resource leakage (thread pools, timers, etc.).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message