axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Glen Mazza (JIRA)" <j...@apache.org>
Subject [jira] Created: (AXIS2-4570) Remove optimizeContent objects and arguments from ADB-generated stubs?
Date Mon, 30 Nov 2009 21:27:20 GMT
Remove optimizeContent objects and arguments from ADB-generated stubs?
----------------------------------------------------------------------

                 Key: AXIS2-4570
                 URL: https://issues.apache.org/jira/browse/AXIS2-4570
             Project: Axis 2.0 (Axis2)
          Issue Type: Improvement
          Components: adb
    Affects Versions: 1.5.1
            Reporter: Glen Mazza
            Priority: Minor
             Fix For: 1.5.1


Axis2 1.4.1 and 1.5.1 (and probably all older versions) are providing an opNameArray object
and optimizeContent method that serve no purpose within the ADB-generated stubs:

    private javax.xml.namespace.QName[] opNameArray = null;
    private boolean optimizeContent(javax.xml.namespace.QName opName) {  // *always* returns
false
        if (opNameArray == null) {
            return false;
        }
        for (int i = 0; i < opNameArray.length; i++) {
            if (opName.equals(opNameArray[i])) {
                return true;   
            }
        }
        return false;
    }

Also, the toOM() and toEnvelope() methods generated in the stubs take an optimizeContent argument
that both method implementations ignore.  Further, all callers to those methods just call
the above optimizeContent() method, which invariably returns false.

These methods are adding unnecessarily to processing overhead and make the generated code
more confusing.  To simplify things it would be good if you could remove the optimizeContent()
method above, the opNameArray object, and the optimizeContent boolean arguments from the generated
toOM() and toEnvelope() methods.  


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message