Return-Path: Delivered-To: apmail-ws-axis-dev-archive@www.apache.org Received: (qmail 10123 invoked from network); 8 Sep 2009 16:50:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Sep 2009 16:50:23 -0000 Received: (qmail 21189 invoked by uid 500); 8 Sep 2009 16:50:22 -0000 Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org Received: (qmail 21072 invoked by uid 500); 8 Sep 2009 16:50:22 -0000 Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@ws.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list axis-dev@ws.apache.org Received: (qmail 21056 invoked by uid 99); 8 Sep 2009 16:50:21 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2009 16:50:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 08 Sep 2009 16:50:18 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 7702C234C044 for ; Tue, 8 Sep 2009 09:49:57 -0700 (PDT) Message-ID: <1991113974.1252428597480.JavaMail.jira@brutus> Date: Tue, 8 Sep 2009 09:49:57 -0700 (PDT) From: "Rich Scheuerle (JIRA)" To: axis-dev@ws.apache.org Subject: [jira] Work started: (AXIS2-4463) Unreachable code in JAXBAttachmentUnmarshaller In-Reply-To: <2059569867.1250335334870.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/AXIS2-4463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on AXIS2-4463 started by Rich Scheuerle. > Unreachable code in JAXBAttachmentUnmarshaller > ---------------------------------------------- > > Key: AXIS2-4463 > URL: https://issues.apache.org/jira/browse/AXIS2-4463 > Project: Axis 2.0 (Axis2) > Issue Type: Bug > Components: jaxws > Reporter: Andreas Veithen > Assignee: Rich Scheuerle > Priority: Minor > > While reviewing some code, I noticed that org.apache.axis2.datasource.jaxb.JAXBAttachmentUnmarshaller contains unreachable code. There are two places where the following if statement is used: > if (xmlStreamReader instanceof OMXMLStreamReader) { > ... > } > "xmlStreamReader" is an attribute of JAXBAttachmentUnmarshaller, but this attribute is never initialized and remains null (this is obviously a bug; see code in the constructor). Since "null instanceof X" is always false, the code inside the if statement is unreachable. > Since this code is related to XOP/MTOM processing, I'm wondering how it is possible that MTOM actually works in JAX-WS (does it?). Also it would be interesting to analyze why this issue doesn't trigger any test failure. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.