Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: axis-dev@ws.apache.org
Message-ID: <2059569867.1250335334870.JavaMail.jira@brutus>
Date: Sat, 15 Aug 2009 04:22:14 -0700 (PDT)
From: "Andreas Veithen (JIRA)" <jira@apache.org>
To: axis-dev@ws.apache.org
Subject: [jira] Created: (AXIS2-4463) Unreachable code in
 JAXBAttachmentUnmarshaller
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Unreachable code in JAXBAttachmentUnmarshaller
----------------------------------------------

                 Key: AXIS2-4463
                 URL: https://issues.apache.org/jira/browse/AXIS2-4463
             Project: Axis 2.0 (Axis2)
          Issue Type: Bug
          Components: jaxws
            Reporter: Andreas Veithen
            Priority: Minor


While reviewing some code, I noticed that org.apache.axis2.datasource.jaxb.JAXBAttachmentUnmarshaller contains unreachable code. There are two places where the following if statement is used:

if (xmlStreamReader instanceof OMXMLStreamReader) {
    ...
}

"xmlStreamReader" is an attribute of JAXBAttachmentUnmarshaller, but this attribute is never initialized and remains null (this is obviously a bug; see code in the constructor). Since "null instanceof X" is always false, the code inside the if statement is unreachable.

Since this code is related to XOP/MTOM processing, I'm wondering how it is possible that MTOM actually works in JAX-WS (does it?). Also it would be interesting to analyze why this issue doesn't trigger any test failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.