axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sanjiva Weerawarana <sanj...@opensource.lk>
Subject Re: Please revert API changes done as per AXIS2-4465
Date Thu, 20 Aug 2009 16:24:12 GMT
+1; the response to changing a public API shouldn't be a request to create a
unit test to retain the API! Unit tests aren't meant to "save an API";
they're meant to test behavior.

Sanjiva.

On Thu, Aug 20, 2009 at 7:31 PM, Afkham Azeez <afkham@gmail.com> wrote:

> Creating a unit test is one thing which we can do, but Axis2 has so
> many public methods, and it is not reasonable at this moment to ask
> anybody to create unit tests for each of these public methods. I guess
> there is a purpose in the widely used practice of deprecating methods.
> Imagine if the other projects that we widely use make such ad-hoc API
> changes, and when we complain, if they ask us to write a unit test for
> their APIs; it is not reasonable. We do not want to make life
> complicated for everybody.
>
> Azeez
>
> On Thu, Aug 20, 2009 at 12:49 PM, Davanum Srinivas<davanum@gmail.com>
> wrote:
> > Azeez,
> >
> > Do you mind creating a unit test(s) for the behavior/API(s) you need?
> That
> > would help keep desired behavior and enforce that what you need will not
> be
> > modified.
> >
> > thanks,
> > dims
> >
> > On 08/20/2009 07:45 AM, Afkham Azeez wrote:
> >>
> >> Yes Dims. However, if everybody continues to merrily change APIs,
> >> making public methods private&  so on, things are going to become a
> >> big mess. Axis2 provides public APIs, and those may be having
> >> problems, but still they are public APIs. This is why you have to be
> >> very careful when defining APIs; if you get them wrong, you may have
> >> to live with it for a long time.
> >>
> >> Azeez
> >>
> >> On Thu, Aug 20, 2009 at 11:38 AM, Davanum Srinivas<davanum@gmail.com>
> >>  wrote:
> >>>
> >>> Azeez,
> >>>
> >>> We are still following, commit-then-review right?
> >>>
> >>> thanks,
> >>> dims
> >>>
> >>> On 08/20/2009 07:33 AM, Afkham Azeez wrote:
> >>>>
> >>>> Hi Andreas,
> >>>> The changes you've done to the APIs as per
> >>>> https://issues.apache.org/jira/browse/AXIS2-4465 badly breaks some of
> >>>> the projects that depend on Axis2. Please revert this, and please
> >>>> engage the community before making such drastic changes in the future.
> >>>>
> >>>
> >>
> >>
> >>
> >
>
>
>
> --
> Thanks
> Afkham Azeez
>
> Blog: http://afkham.org
> Developer Portal: http://www.wso2.org
> WSAS Blog: http://wso2wsas.blogspot.com
> Company: http://wso2.com
> GPG Fingerprint: 643F C2AF EB78 F886 40C9  B2A2 4AE2 C887 665E 0760
>



-- 
Sanjiva Weerawarana, Ph.D.
Founder, Director & Chief Scientist; Lanka Software Foundation;
http://www.opensource.lk/
Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
Member; Apache Software Foundation; http://www.apache.org/
Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/

Blog: http://sanjiva.weerawarana.org/

Mime
View raw message