axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Veithen <andreas.veit...@gmail.com>
Subject Re: Please revert API changes done as per AXIS2-4465
Date Thu, 20 Aug 2009 19:10:47 GMT
On Thu, Aug 20, 2009 at 18:08, Senaka Fernando<senaka@wso2.com> wrote:
> Hi Andreas,
>
> Just wondering what you are trying to achieve here.

Fixing AxisServlet so that it works as expected, i.e. deliver the
functionalities that the existing code promised to implement, but
failed to deliver.

> Is this related to auto
> detection of ports as Hiranya pointed out?

Yes. Note that port autodetection has always been part of the code,
but it was deeply buried in the code. It is now done at the right
level, i.e. at the same level where we do autodetection of the context
path.

> While I appreciate the effort
> you've put into doing something worthwhile, I believe that getting rid of a
> public method in a class is not the correct thing to do.

As explained earlier, it is not the purpose of the fix to get rid of
this public method and this will be undone.

> I believe that what
> you have done here is the addition of a new portion of code. Can we make the
> new portion of code optional?

Since it is supposed to replace pieces of code that didn't work as
expected, there is no point in making them optional. It's either
accepting the change or design a different fix that solves these
issues.

> And leave the existing logic as it was?

The existing logic is responsible for 6 JIRAs and complaints on the
mailing list.

> Also,
> are you planning further changes to this class?

We need to make sure that SynapseAxisServlet can safely extend
AxisServlet without tight coupling to the internals of AxisServlet.
This will probably require some (hopefully non breaking) changes in
AxisServlet.

> if so, it would perhaps be
> better to figure out a more elaborate solution, which safeguards both the
> existing level of extensibility of this class and also its public API.

The problem is that AxisServlet is not designed to be extensible. That
is the fundamental problem we need to find a solution for. Any
suggestions are welcome.

>
> Thanks,
> Senaka
>
> On Thu, Aug 20, 2009 at 6:14 PM, Hiranya Jayathilaka <hiranya911@gmail.com>
> wrote:
>>
>> Hi Andreas,
>>
>> By looking at the code I got the impression that HTTP transport receivers
>> should extend the AxisServletListener class for your logic of port auto
>> detection to work. Is that correct? What happens if the transport receivers
>> used do not extend this class? All request handler methods call the
>> preprocessRequest method which in turns run port auto detection. If the
>> transport receivers do not extend AxisServlerListener how is that handled?
>>
>> Thanks,
>> Hiranya
>>
>>
>> On Thu, Aug 20, 2009 at 6:05 PM, Andreas Veithen
>> <andreas.veithen@gmail.com> wrote:
>>>
>>> Afkham,
>>>
>>> The only change I see in the public APIs is the disappearance of the
>>> initContextRoot method. We can easily fix this be restoring the
>>> original initContextRoot method and let the preprocessRequest method
>>> call initContextRoot. Do you see any other things to change?
>>>
>>> Andreas
>>>
>>> On Thu, Aug 20, 2009 at 13:45, Afkham Azeez<afkham@gmail.com> wrote:
>>> > Yes Dims. However, if everybody continues to merrily change APIs,
>>> > making public methods private & so on, things are going to become a
>>> > big mess. Axis2 provides public APIs, and those may be having
>>> > problems, but still they are public APIs. This is why you have to be
>>> > very careful when defining APIs; if you get them wrong, you may have
>>> > to live with it for a long time.
>>> >
>>> > Azeez
>>> >
>>> > On Thu, Aug 20, 2009 at 11:38 AM, Davanum Srinivas<davanum@gmail.com>
>>> > wrote:
>>> >> Azeez,
>>> >>
>>> >> We are still following, commit-then-review right?
>>> >>
>>> >> thanks,
>>> >> dims
>>> >>
>>> >> On 08/20/2009 07:33 AM, Afkham Azeez wrote:
>>> >>>
>>> >>> Hi Andreas,
>>> >>> The changes you've done to the APIs as per
>>> >>> https://issues.apache.org/jira/browse/AXIS2-4465 badly breaks some
of
>>> >>> the projects that depend on Axis2. Please revert this, and please
>>> >>> engage the community before making such drastic changes in the
>>> >>> future.
>>> >>>
>>> >>
>>> >
>>> >
>>> >
>>> > --
>>> > Thanks
>>> > Afkham Azeez
>>> >
>>> > Blog: http://afkham.org
>>> > Developer Portal: http://www.wso2.org
>>> > WSAS Blog: http://wso2wsas.blogspot.com
>>> > Company: http://wso2.com
>>> > GPG Fingerprint: 643F C2AF EB78 F886 40C9  B2A2 4AE2 C887 665E 0760
>>> >
>>
>>
>>
>> --
>> Hiranya Jayathilaka
>> Software Engineer;
>> WSO2 Inc.;  http://wso2.org
>> E-mail: hiranya@wso2.com;  Mobile: +94 77 633 3491
>> Blog: http://techfeast-hiranya.blogspot.com
>
>

Mime
View raw message