axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amila Chinthaka Suriarachchi (JIRA)" <j...@apache.org>
Subject [jira] Updated: (AXIS2-4477) wsdl2java should only prettify files it has generated itself
Date Thu, 27 Aug 2009 06:34:59 GMT

     [ https://issues.apache.org/jira/browse/AXIS2-4477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Amila Chinthaka Suriarachchi updated AXIS2-4477:
------------------------------------------------

    Attachment: codegen.patch

Here is a patch for the two issue pointed out by the Andreas.

Here at the AbstractPrettyPrinterExtension keeps the generic logic of traversing through the
files letting other sub classes to override it.

Please have a look. will apply the patch if there are no more issues.

> wsdl2java should only prettify files it has generated itself
> ------------------------------------------------------------
>
>                 Key: AXIS2-4477
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4477
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: codegen
>    Affects Versions: 1.5.1, 1.5, 1.4.1
>            Reporter: Andreas Veithen
>            Priority: Minor
>         Attachments: codegen.patch
>
>
> In AXIS2-2947 it was requested to make the prettify feature in wsdl2java more selective,
but this has only been done for XML files. The problem still persists for Java files: if the
output directory contains Java files that have not been generated by wsdl2java, then these
files will be reformatted too. The prettify feature should be strictly limited to files that
have been generated by wsdl2java.
> Additional notes:
> - The fact that JavaPrettyPrinterExtension scans the entire output directory is the actual
root cause of AXIS2-4107.
> - The change in AXIS2-2947 has a severe design flaw because it changed AbstractPrettyPrinterExtension
to limit itself to generated XML files. It should limit itself to files of any type generated
by wsdl2java and give subclasses the opportunity to filter these files by type.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message