axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hiranya Jayathilaka <hiranya...@gmail.com>
Subject Re: Please revert API changes done as per AXIS2-4465
Date Thu, 20 Aug 2009 12:44:02 GMT
Hi Andreas,

By looking at the code I got the impression that HTTP transport receivers
should extend the AxisServletListener class for your logic of port auto
detection to work. Is that correct? What happens if the transport receivers
used do not extend this class? All request handler methods call the
preprocessRequest method which in turns run port auto detection. If the
transport receivers do not extend AxisServlerListener how is that handled?

Thanks,
Hiranya


On Thu, Aug 20, 2009 at 6:05 PM, Andreas Veithen
<andreas.veithen@gmail.com>wrote:

> Afkham,
>
> The only change I see in the public APIs is the disappearance of the
> initContextRoot method. We can easily fix this be restoring the
> original initContextRoot method and let the preprocessRequest method
> call initContextRoot. Do you see any other things to change?
>
> Andreas
>
> On Thu, Aug 20, 2009 at 13:45, Afkham Azeez<afkham@gmail.com> wrote:
> > Yes Dims. However, if everybody continues to merrily change APIs,
> > making public methods private & so on, things are going to become a
> > big mess. Axis2 provides public APIs, and those may be having
> > problems, but still they are public APIs. This is why you have to be
> > very careful when defining APIs; if you get them wrong, you may have
> > to live with it for a long time.
> >
> > Azeez
> >
> > On Thu, Aug 20, 2009 at 11:38 AM, Davanum Srinivas<davanum@gmail.com>
> wrote:
> >> Azeez,
> >>
> >> We are still following, commit-then-review right?
> >>
> >> thanks,
> >> dims
> >>
> >> On 08/20/2009 07:33 AM, Afkham Azeez wrote:
> >>>
> >>> Hi Andreas,
> >>> The changes you've done to the APIs as per
> >>> https://issues.apache.org/jira/browse/AXIS2-4465 badly breaks some of
> >>> the projects that depend on Axis2. Please revert this, and please
> >>> engage the community before making such drastic changes in the future.
> >>>
> >>
> >
> >
> >
> > --
> > Thanks
> > Afkham Azeez
> >
> > Blog: http://afkham.org
> > Developer Portal: http://www.wso2.org
> > WSAS Blog: http://wso2wsas.blogspot.com
> > Company: http://wso2.com
> > GPG Fingerprint: 643F C2AF EB78 F886 40C9  B2A2 4AE2 C887 665E 0760
> >
>



-- 
Hiranya Jayathilaka
Software Engineer;
WSO2 Inc.;  http://wso2.org
E-mail: hiranya@wso2.com;  Mobile: +94 77 633 3491
Blog: http://techfeast-hiranya.blogspot.com

Mime
View raw message