Return-Path: Delivered-To: apmail-ws-axis-dev-archive@www.apache.org Received: (qmail 85952 invoked from network); 12 Dec 2008 18:39:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Dec 2008 18:39:56 -0000 Received: (qmail 5234 invoked by uid 500); 12 Dec 2008 18:40:03 -0000 Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org Received: (qmail 5184 invoked by uid 500); 12 Dec 2008 18:40:03 -0000 Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@ws.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list axis-dev@ws.apache.org Received: (qmail 5175 invoked by uid 99); 12 Dec 2008 18:40:02 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Dec 2008 10:40:02 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [67.19.18.210] (HELO aalto.aaltohost.com) (67.19.18.210) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Dec 2008 18:39:41 +0000 Received: by aalto.aaltohost.com (Postfix, from userid 1017) id 5DC1F48922C; Fri, 12 Dec 2008 12:39:20 -0600 (CST) Received: from [192.168.1.3] (pool-96-237-119-225.bstnma.fios.verizon.net [96.237.119.225]) (using SMTP over TLS) by localhost.localdomain (tmda-ofmipd) with ESMTP; Fri, 12 Dec 2008 12:39:17 -0600 Message-ID: <4942AF6A.4090704@thoughtcraft.com> Date: Fri, 12 Dec 2008 13:37:30 -0500 User-Agent: Thunderbird 2.0.0.18 (Windows/20081105) MIME-Version: 1.0 To: axis-dev@ws.apache.org Subject: Re: Looking into open issue 3364 References: <49427410.40607@gmail.com> In-Reply-To: <49427410.40607@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Delivery-Agent: TMDA/1.1.12 (Macallan) From: Glen Daniels X-Virus-Checked: Checked by ClamAV on apache.org Hi Deepal: Deepal jayasinghe wrote: > As I mentioned in the JIRA, I did a local fix and get that working, > however most of the java2wsdl and some runtime code generation tests > failed. So I did not commit the changes. My changes only involve in > SchemaGenerator, and it is very simple fix. Only thing is to make sure > you get the test cases working. Currently for any input type it sets > minoccurs to 0 , so you just need to change that to 1. So you're saying we shouldn't support optional parameters, and therefore we should be throwing an exception for missing parameters? And we shouldn't be able to pass null values? Hmm... I think we should be able to be as expressive and simple as possible in making our schemas align with the Java structure - and supporting missing wire parameters which will become null values for Object types certainly seems reasonable toward that end. In other words, IMO we should support on the server side: Type Result if missing Schema ---------------------------------------------------------- primitive exception minOc=1 Object null minOc=0 Also, this way if the client wants to send a null there's a way to do it (don't include the param). This doesn't seem that hard to do, and I think it makes for nicer REST URLs and SOAP messages in some cases. Thoughts? --Glen