axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Davanum Srinivas" <dava...@gmail.com>
Subject Re: Committing patch contributed for MIME message parser and serializer based on Apache mime4j [WSCOMMONS-387]
Date Thu, 20 Nov 2008 16:34:49 GMT
Oleg,

I totally agreed with you if you scroll back a few emails. Yes, we
need to fix *that*. Any patch to do that will be *very* welcome.

thanks,
-- dims

On Thu, Nov 20, 2008 at 11:31 AM, Oleg Kalnichevski <olegk@apache.org> wrote:
> On Thu, 2008-11-20 at 10:08 -0600, Thilina Gunarathne wrote:
>> Hi,
>>
>>
>>         Thilina, while I agree with "don't fix if it ain't broke",
>>         this is an *improvement* .. not a fix for the sake of a fix. I
>>         think we should do it.
>>
>> As even Oleg mentioned the MIME4J is around 15% slower than the
>> current impl..  IMHO the issue which this patch tries to address (in
>> memory buffering of SOAP part) is not much of an issue when used with
>> attachments, cause most of the time people use small soap envelopes
>> when they use attachments. Also I'm not sure whether MIME4J is as
>> battle tested as the Axis2's current implementation.
>>
>
> The real issue here has nothing to do with performance or even
> unnecessary in-memory buffering. It is rather about inflexibility of the
> existing MIME processing API and the hard coupling of what is meant to
> be an abstract API with Attachment impl classes. Mime4j is merely an
> implementation detail.
>
> Oleg
>
>>
>> I totally agree that we should support MIME4J and we should do
>> "improvements".. But since this does not come with any urgent fixes
>> for something that's badly broken, I would prefer to do it in a little
>> bit of a controlled fashion.. May be support both the impl's or do
>> this in a branch first.
>>
>>
>> Also I'm sorry, but I don't really like the approach people are taking
>> in this issue.. Why is it that the decision is between commit the
>> patch directly to trunk  or throw away... Why cant' we come to a
>> middle ground..
>>
>>
>> thanks,
>> Thilina
>>
>>
>>
>>
>>         If it breaks something (like interop) we can always revert ..
>>
>>         Sanjiva.
>>         --
>>         Sanjiva Weerawarana, Ph.D.
>>         Founder & Director; Lanka Software Foundation;
>>         http://www.opensource.lk/
>>         Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
>>         Member; Apache Software Foundation; http://www.apache.org/
>>         Visiting Lecturer; University of Moratuwa;
>>         http://www.cse.mrt.ac.lk/
>>
>>         Blog: http://sanjiva.weerawarana.org/
>>
>>
>>
>> --
>> Thilina Gunarathne  - http://thilinag.blogspot.com
>
>



-- 
Davanum Srinivas :: http://davanum.wordpress.com

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Mime
View raw message