axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r...@apache.org
Subject svn commit: r702617 - in /webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/client: dispatch/BaseDispatch.java proxy/JAXWSProxyHandler.java
Date Tue, 07 Oct 2008 20:34:04 GMT
Author: rott
Date: Tue Oct  7 13:34:04 2008
New Revision: 702617

URL: http://svn.apache.org/viewvc?rev=702617&view=rev
Log:
Allow client applications to share session cookies among BindingProvider and Dispatch instances

Modified:
    webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/client/dispatch/BaseDispatch.java
    webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/client/proxy/JAXWSProxyHandler.java

Modified: webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/client/dispatch/BaseDispatch.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/client/dispatch/BaseDispatch.java?rev=702617&r1=702616&r2=702617&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/client/dispatch/BaseDispatch.java
(original)
+++ webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/client/dispatch/BaseDispatch.java
Tue Oct  7 13:34:04 2008
@@ -38,6 +38,7 @@
 import org.apache.axis2.jaxws.spi.Constants;
 import org.apache.axis2.jaxws.spi.ServiceDelegate;
 import org.apache.axis2.jaxws.spi.migrator.ApplicationContextMigratorUtil;
+import org.apache.axis2.transport.http.HTTPConstants;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
@@ -141,6 +142,25 @@
 
             initMessageContext(obj, requestMsgCtx);
 
+            /*
+             * if SESSION_MAINTAIN_PROPERTY is true, and the client app has explicitly set
a HEADER_COOKIE on the request context, assume the client
+             * app is expecting the HEADER_COOKIE to be the session id.  If we were establishing
a new session, no cookie would be sent, and the 
+             * server would reply with a "Set-Cookie" header, which is copied as a "Cookie"-keyed
property to the service context during response.
+             * In this case, if we succeed in using an existing server session, no "Set-Cookie"
header will be returned, and therefore no
+             * "Cookie"-keyed property would be set on the service context.  So, let's copy
our request context HEADER_COOKIE key to the service
+             * context now to prevent the "no cookie" exception in BindingProvider.setupSessionContext.
 It is possible the server does not support
+             * sessions, in which case no error occurs, but the client app would assume it
is participating in a session.
+             */
+            if ((requestContext.containsKey(BindingProvider.SESSION_MAINTAIN_PROPERTY)) &&
((Boolean)requestContext.get(BindingProvider.SESSION_MAINTAIN_PROPERTY))) {
+                if ((requestContext.containsKey(HTTPConstants.HEADER_COOKIE)) &&
(requestContext.get(HTTPConstants.HEADER_COOKIE) != null)) {
+                    invocationContext.getServiceClient().getServiceContext().setProperty(HTTPConstants.HEADER_COOKIE,
requestContext.get(HTTPConstants.HEADER_COOKIE));
+                    if (log.isDebugEnabled()) {
+                        log.debug("Client-app defined Cookie property (assume to be session
cookie) on request context copied to service context." +
+                                "  Caution:  server may or may not support sessions, but
client app will not be informed when not supported.");
+                    }
+                }
+            }
+            
             // Migrate the properties from the client request context bag to
             // the request MessageContext.
             ApplicationContextMigratorUtil.performMigrationToMessageContext(

Modified: webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/client/proxy/JAXWSProxyHandler.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/client/proxy/JAXWSProxyHandler.java?rev=702617&r1=702616&r2=702617&view=diff
==============================================================================
--- webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/client/proxy/JAXWSProxyHandler.java
(original)
+++ webservices/axis2/trunk/java/modules/jaxws/src/org/apache/axis2/jaxws/client/proxy/JAXWSProxyHandler.java
Tue Oct  7 13:34:04 2008
@@ -39,6 +39,7 @@
 import org.apache.axis2.jaxws.spi.Constants;
 import org.apache.axis2.jaxws.spi.ServiceDelegate;
 import org.apache.axis2.jaxws.spi.migrator.ApplicationContextMigratorUtil;
+import org.apache.axis2.transport.http.HTTPConstants;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
@@ -203,6 +204,25 @@
         requestIC.setRequestMessageContext(request);
         requestIC.setServiceClient(serviceDelegate.getServiceClient(endpointDesc.getPortQName()));
         
+        /*
+         * if SESSION_MAINTAIN_PROPERTY is true, and the client app has explicitly set a
HEADER_COOKIE on the request context, assume the client
+         * app is expecting the HEADER_COOKIE to be the session id.  If we were establishing
a new session, no cookie would be sent, and the 
+         * server would reply with a "Set-Cookie" header, which is copied as a "Cookie"-keyed
property to the service context during response.
+         * In this case, if we succeed in using an existing server session, no "Set-Cookie"
header will be returned, and therefore no
+         * "Cookie"-keyed property would be set on the service context.  So, let's copy our
request context HEADER_COOKIE key to the service
+         * context now to prevent the "no cookie" exception in BindingProvider.setupSessionContext.
 It is possible the server does not support
+         * sessions, in which case no error occurs, but the client app would assume it is
participating in a session.
+         */
+        if ((requestContext.containsKey(BindingProvider.SESSION_MAINTAIN_PROPERTY)) &&
((Boolean)requestContext.get(BindingProvider.SESSION_MAINTAIN_PROPERTY))) {
+            if ((requestContext.containsKey(HTTPConstants.HEADER_COOKIE)) && (requestContext.get(HTTPConstants.HEADER_COOKIE)
!= null)) {
+                requestIC.getServiceClient().getServiceContext().setProperty(HTTPConstants.HEADER_COOKIE,
requestContext.get(HTTPConstants.HEADER_COOKIE));
+                if (log.isDebugEnabled()) {
+                    log.debug("Client-app defined Cookie property (assume to be session cookie)
on request context copied to service context." +
+                            "  Caution:  server may or may not support sessions, but client
app will not be informed when not supported.");
+                }
+            }
+        }
+        
         // Migrate the properties from the client request context bag to
         // the request MessageContext.
         ApplicationContextMigratorUtil.performMigrationToMessageContext(



Mime
View raw message