Return-Path: Delivered-To: apmail-ws-axis-dev-archive@www.apache.org Received: (qmail 69605 invoked from network); 8 Aug 2008 08:36:24 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Aug 2008 08:36:24 -0000 Received: (qmail 58426 invoked by uid 500); 8 Aug 2008 08:36:17 -0000 Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org Received: (qmail 58405 invoked by uid 500); 8 Aug 2008 08:36:17 -0000 Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@ws.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list axis-dev@ws.apache.org Received: (qmail 58393 invoked by uid 99); 8 Aug 2008 08:36:17 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Aug 2008 01:36:17 -0700 X-ASF-Spam-Status: No, hits=-2.0 required=10.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of PRADINE@uk.ibm.com designates 195.212.29.136 as permitted sender) Received: from [195.212.29.136] (HELO mtagate3.uk.ibm.com) (195.212.29.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 08 Aug 2008 08:35:19 +0000 Received: from d06nrmr1407.portsmouth.uk.ibm.com (d06nrmr1407.portsmouth.uk.ibm.com [9.149.38.185]) by mtagate3.uk.ibm.com (8.13.8/8.13.8) with ESMTP id m788ZKum139996 for ; Fri, 8 Aug 2008 08:35:20 GMT Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by d06nrmr1407.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m788ZJix3403820 for ; Fri, 8 Aug 2008 09:35:19 +0100 Received: from d06av04.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m788ZJmP002793 for ; Fri, 8 Aug 2008 09:35:19 +0100 Received: from d06ml065.portsmouth.uk.ibm.com (d06ml065.portsmouth.uk.ibm.com [9.149.38.138]) by d06av04.portsmouth.uk.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m788ZJKu002786; Fri, 8 Aug 2008 09:35:19 +0100 In-Reply-To: <489BE5D6.9060409@thoughtcraft.com> X-Disclaimed: 35042 To: Glen Daniels Cc: Axis-Dev , pradine@apache.org MIME-Version: 1.0 Subject: Re: svn commit: r683656 - in /webservices/axis2/trunk/java/modules: addressing/src/org/apache/axis2/handlers/addressing/AddressingValidationHandler.java kernel/src/org/apache/axis2/addressing/AddressingConstants.java X-Mailer: Lotus Notes Release 7.0 HF277 June 21, 2006 From: Brian De Pradine Message-ID: Date: Fri, 8 Aug 2008 09:35:17 +0100 X-MIMETrack: Serialize by Router on D06ML065/06/M/IBM(Release 7.0.2FP2HF322 | September 26, 2007) at 08/08/2008 09:35:19, Serialize complete at 08/08/2008 09:35:19 Content-Type: multipart/alternative; boundary="=_alternative 002F2AA58025749F_=" X-Virus-Checked: Checked by ClamAV on apache.org --=_alternative 002F2AA58025749F_= Content-Type: text/plain; charset="US-ASCII" Hi Glen, Yes, sorry about that. There is now a new test in the kernel module, AddressingBasedDispatcherTest, to cover that function. Cheers Brian DePradine Web Services Development IBM Hursley External +44 (0) 1962 816319 Internal 246319 If you can't find the time to do it right the first time, where will you find the time to do it again? Glen Daniels wrote on 08/08/2008 07:21:10: > Hi Brian: > > This commit caused a broken build (NPE at > AddressingValidationHandler.java:51), so I commented out the test which > confirms that the ADDR_VALIDATE_ACTION flag works. I haven't been > tracking what's up with this... can you vet that things are working as > expected? Is this functionality used by Synapse? > > Thanks, > --Glen > > pradine@apache.org wrote: > > Author: pradine > > Date: Thu Aug 7 10:30:38 2008 > > New Revision: 683656 > > > > URL: http://svn.apache.org/viewvc?rev=683656&view=rev > > Log: > > Allow components to disable the invocation pattern validation > performed by WS-Addressing. > > > > Modified: > > > webservices/axis2/trunk/java/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingValidationHandler. > java > > > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/AddressingConstants. > java > > > > Modified: > webservices/axis2/trunk/java/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingValidationHandler. > java > > URL: http://svn.apache. > org/viewvc/webservices/axis2/trunk/java/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingValidationHandler. > java?rev=683656&r1=683655&r2=683656&view=diff > > > ============================================================================== > > --- > webservices/axis2/trunk/java/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingValidationHandler. > java (original) > > +++ > webservices/axis2/trunk/java/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingValidationHandler. > java Thu Aug 7 10:30:38 2008 > > @@ -48,24 +48,18 @@ > > } > > > > if (JavaUtils.isTrueExplicitly(flag)) { > > - // If no AxisOperation has been found at the end of > the dispatch phase and addressing > > - // is in use we should throw an ActionNotSupported > Fault, unless we've been told > > - // not to do this check (by Synapse, for instance) > > - if (JavaUtils.isTrue(msgContext. > getProperty(ADDR_VALIDATE_ACTION), true)) { > > - // Check if the wsa:MessageID is required or not. > > - checkMessageIDHeader(msgContext); > > - } > > + // Check if the wsa:MessageID is required or not. > > + checkMessageIDHeader(msgContext); > > } > > - > > - if (JavaUtils.isFalseExplicitly(flag)) { > > + else { > > // Check that if wsaddressing=required that > addressing headers were found inbound > > checkUsingAddressing(msgContext); > > } > > > > - // Check that if wsamInvocationPattern flag is in effect > that the replyto and faultto are valid > > - // This method must always be called to ensure that the > async required invocation pattern is > > - // enforced. > > - checkWSAMInvocationPattern(msgContext); > > + // Check that if wsamInvocationPattern flag is in effect > that the replyto and faultto are valid. > > + if (JavaUtils.isTrue(msgContext. > getProperty(ADDR_VALIDATE_INVOCATION_PATTERN), true)) { > > + checkWSAMInvocationPattern(msgContext); > > + } > > > > return InvocationResponse.CONTINUE; > > } > > @@ -106,7 +100,7 @@ > > String value = > > AddressingHelper. > getInvocationPatternParameterValue(msgContext.getAxisOperation()); > > if (log.isTraceEnabled()) { > > - log.trace("checkAnonymous: value=" + value); > > + log.trace("checkWSAMInvocationPattern: value=" + value); > > } > > if(!AddressingConstants.WSAM_INVOCATION_PATTERN_BOTH. > equals(value)){ > > if (WSAM_INVOCATION_PATTERN_SYNCHRONOUS.equals(value)) { > > > > Modified: > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/AddressingConstants. > java > > URL: http://svn.apache. > org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/AddressingConstants. > java?rev=683656&r1=683655&r2=683656&view=diff > > > ============================================================================== > > --- > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/AddressingConstants. > java (original) > > +++ > webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/AddressingConstants. > java Thu Aug 7 10:30:38 2008 > > @@ -47,6 +47,7 @@ > > static final String IS_ADDR_INFO_ALREADY_PROCESSED = > "IsAddressingProcessed"; > > static final String DISABLE_ADDRESSING_FOR_IN_MESSAGES = > "disableAddressingForInMessages"; > > static final String ADDR_VALIDATE_ACTION = "addressing.validateAction"; > > + static final String ADDR_VALIDATE_INVOCATION_PATTERN = > "addressing.validateInvocationPattern"; > > > > // ====================== WSDL Binding Constants > ======================== > > static final String USING_ADDRESSING = "UsingAddressing"; > > > > Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU --=_alternative 002F2AA58025749F_= Content-Type: text/html; charset="US-ASCII"
Hi Glen,

Yes, sorry about that. There is now a new test in the kernel module, AddressingBasedDispatcherTest, to cover that function.

Cheers

Brian DePradine
Web Services Development
IBM Hursley
External  +44 (0) 1962 816319         Internal 246319

If you can't find the time to do it right the first time, where will you find the time to do it again?

Glen Daniels <glen@thoughtcraft.com> wrote on 08/08/2008 07:21:10:

> Hi Brian:
>
> This commit caused a broken build (NPE at
> AddressingValidationHandler.java:51), so I commented out the test which
> confirms that the ADDR_VALIDATE_ACTION flag works.  I haven't been
> tracking what's up with this... can you vet that things are working as
> expected?  Is this functionality used by Synapse?
>
> Thanks,
> --Glen
>
> pradine@apache.org wrote:
> > Author: pradine
> > Date: Thu Aug  7 10:30:38 2008
> > New Revision: 683656
> >
> > URL: http://svn.apache.org/viewvc?rev=683656&view=rev
> > Log:
> > Allow components to disable the invocation pattern validation
> performed by WS-Addressing.
> >
> > Modified:
> >    
> webservices/axis2/trunk/java/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingValidationHandler.
> java
> >    
> webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/AddressingConstants.
> java
> >
> > Modified:
> webservices/axis2/trunk/java/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingValidationHandler.
> java
> > URL: http://svn.apache.
> org/viewvc/webservices/axis2/trunk/java/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingValidationHandler.
> java?rev=683656&r1=683655&r2=683656&view=diff
> >
> ==============================================================================
> > ---
> webservices/axis2/trunk/java/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingValidationHandler.
> java (original)
> > +++
> webservices/axis2/trunk/java/modules/addressing/src/org/apache/axis2/handlers/addressing/AddressingValidationHandler.
> java Thu Aug  7 10:30:38 2008
> > @@ -48,24 +48,18 @@
> >          }
> >  
> >          if (JavaUtils.isTrueExplicitly(flag)) {
> > -            // If no AxisOperation has been found at the end of
> the dispatch phase and addressing
> > -            // is in use we should throw an ActionNotSupported
> Fault, unless we've been told
> > -            // not to do this check (by Synapse, for instance)
> > -            if (JavaUtils.isTrue(msgContext.
> getProperty(ADDR_VALIDATE_ACTION), true)) {
> > -                // Check if the wsa:MessageID is required or not.
> > -                checkMessageIDHeader(msgContext);
> > -            }
> > +            // Check if the wsa:MessageID is required or not.
> > +            checkMessageIDHeader(msgContext);
> >          }
> > -
> > -        if (JavaUtils.isFalseExplicitly(flag)) {
> > +        else {
> >              // Check that if wsaddressing=required that
> addressing headers were found inbound
> >              checkUsingAddressing(msgContext);
> >          }
> >          
> > -        // Check that if wsamInvocationPattern flag is in effect
> that the replyto and faultto are valid
> > -        // This method must always be called to ensure that the
> async required invocation pattern is
> > -        // enforced.
> > -        checkWSAMInvocationPattern(msgContext);
> > +        // Check that if wsamInvocationPattern flag is in effect
> that the replyto and faultto are valid.
> > +        if (JavaUtils.isTrue(msgContext.
> getProperty(ADDR_VALIDATE_INVOCATION_PATTERN), true)) {
> > +            checkWSAMInvocationPattern(msgContext);
> > +        }
> >  
> >          return InvocationResponse.CONTINUE;
> >      }
> > @@ -106,7 +100,7 @@
> >          String value =
> >                  AddressingHelper.
> getInvocationPatternParameterValue(msgContext.getAxisOperation());
> >          if (log.isTraceEnabled()) {
> > -            log.trace("checkAnonymous: value=" + value);
> > +            log.trace("checkWSAMInvocationPattern: value=" + value);
> >          }
> >          if(!AddressingConstants.WSAM_INVOCATION_PATTERN_BOTH.
> equals(value)){
> >             if (WSAM_INVOCATION_PATTERN_SYNCHRONOUS.equals(value)) {
> >
> > Modified:
> webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/AddressingConstants.
> java
> > URL: http://svn.apache.
> org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/AddressingConstants.
> java?rev=683656&r1=683655&r2=683656&view=diff
> >
> ==============================================================================
> > ---
> webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/AddressingConstants.
> java (original)
> > +++
> webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/addressing/AddressingConstants.
> java Thu Aug  7 10:30:38 2008
> > @@ -47,6 +47,7 @@
> >      static final String IS_ADDR_INFO_ALREADY_PROCESSED =
> "IsAddressingProcessed";
> >      static final String DISABLE_ADDRESSING_FOR_IN_MESSAGES =
> "disableAddressingForInMessages";
> >      static final String ADDR_VALIDATE_ACTION = "addressing.validateAction";
> > +    static final String ADDR_VALIDATE_INVOCATION_PATTERN =
> "addressing.validateInvocationPattern";
> >  
> >      // ====================== WSDL Binding Constants
> ========================
> >      static final String USING_ADDRESSING = "UsingAddressing";
> >
> >





Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU






--=_alternative 002F2AA58025749F_=--