Return-Path: Delivered-To: apmail-ws-axis-dev-archive@www.apache.org Received: (qmail 35698 invoked from network); 10 May 2008 12:21:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 May 2008 12:21:59 -0000 Received: (qmail 65634 invoked by uid 500); 10 May 2008 12:22:00 -0000 Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org Received: (qmail 65522 invoked by uid 500); 10 May 2008 12:22:00 -0000 Mailing-List: contact axis-cvs-help@ws.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list axis-cvs@ws.apache.org Received: (qmail 65498 invoked by uid 500); 10 May 2008 12:22:00 -0000 Delivered-To: apmail-ws-axis2-cvs@ws.apache.org Received: (qmail 65495 invoked by uid 99); 10 May 2008 12:22:00 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 May 2008 05:22:00 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 May 2008 12:21:14 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 49A162388A1A; Sat, 10 May 2008 05:21:35 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r655064 - /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/Handler.java Date: Sat, 10 May 2008 12:21:35 -0000 To: axis2-cvs@ws.apache.org From: barrettj@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20080510122135.49A162388A1A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: barrettj Date: Sat May 10 05:21:34 2008 New Revision: 655064 URL: http://svn.apache.org/viewvc?rev=655064&view=rev Log: Performance improvement for Handler.InvocationResponse submitted by David Strite: make the class and some attributes final, check for reference equality first in equals. Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/Handler.java Modified: webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/Handler.java URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/Handler.java?rev=655064&r1=655063&r2=655064&view=diff ============================================================================== --- webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/Handler.java (original) +++ webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/engine/Handler.java Sat May 10 05:21:34 2008 @@ -110,16 +110,16 @@ * runtime. The returned instruction will determine the next step in * the processing. */ - public class InvocationResponse { - public static InvocationResponse CONTINUE = + public final class InvocationResponse { + public static final InvocationResponse CONTINUE = new InvocationResponse(0, "InvocationResponse.CONTINUE"); - public static InvocationResponse SUSPEND = + public static final InvocationResponse SUSPEND = new InvocationResponse(1, "InvocationResponse.SUSPEND"); - public static InvocationResponse ABORT = + public static final InvocationResponse ABORT = new InvocationResponse(2, "InvocationResponse.ABORT"); - private int instructionID; - private String description; + private final int instructionID; + private final String description; private InvocationResponse(int instructionID, String description) { this.instructionID = instructionID; @@ -131,6 +131,9 @@ } public boolean equals(Object obj) { + if(this==obj) { + return true; + } if (!(obj instanceof InvocationResponse)) { return false; } --------------------------------------------------------------------- To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org For additional commands, e-mail: axis-cvs-help@ws.apache.org