Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: axis-dev@ws.apache.org
Received-SPF: pass (nike.apache.org: domain of samindaa@gmail.com designates
 64.233.184.238 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references;
        b=aT2s/HCMsVDO8TDmoc7NsmCtPa1CrNfb8OVB2NeJfYyft1kVqhpZ7ipE23BtMCfpMUVqpaltrbmZNvWTNrP+MW7VaYgPXd3iYtg1sYzg9Df7Khf6KipZGHBqPXRTcDM29vZiuMyyqn3RoezIwOgyN44QgE8PKi6sh8O2poRIU2E=
Message-ID: <aa8fdb10804070321h3f0dcff0l813166d6f6e6f7db@mail.gmail.com>
Date: Mon, 7 Apr 2008 15:51:06 +0530
From: "Saminda Abeyruwan" <samindaa@gmail.com>
To: axis-dev@ws.apache.org
Subject: Re: svn commit: r644329 -
 /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/http/AxisServlet.java
Cc: gawor@apache.org
In-Reply-To: <20080403143340.3F35C1A9832@eris.apache.org>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_16820_87598.1207563666359"
References: <20080403143340.3F35C1A9832@eris.apache.org>

------=_Part_16820_87598.1207563666359
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

Is there a particular reason to add the line.

msgContext.setProperty(HTTPCon
>
> stants.MC_HTTP_SERVLETCONTEXT, getServletContext());


You will be able to access the context from http servlet request object.

Beside the prior added line will break some of the existing production code.


getServletContext() will work properly, IFF the user's servlet inherit the
init method or if over-rides, it should called the parent init method.

In AxisServlet, yes it dose over-rides the init method and calls the parent
init.

But those of us who have extended AxisServlet to work with, where over-rides
the init method  to intialize the AxisConfiguration the way our production
system wants  does not call the parents (AxisServlet) init method.

ex:
public class MyServlet extends AxisServlet {
    ...
   public void init(ServletConfig config) {
      // my way of initializing axisconfiguration and listeners rather using
parent
     // init, but inheriting parents do* from AxisServlet.
  }

}

We used AxisServlet as show above for quite a long  time.

I'm afraid the prior line of code  has broken the backward compatibility of
re-using AxisServlet in production environments.

Thus, the correct way is to obtain the servlet context from request, rather
setting the property.

Thus, I would humbly ask to revert the commit to preserve backward
compatibility.

Thank you!

Saminda


>         msgContext.setProperty(MessageContext.TRANSPORT_HEADERS,
> getTransportHeaders(request));
>         msgContext.setProperty(HTTPConstants.MC_HTTP_SERVLETREQUEST,
> request);
>         msgContext.setProperty(HTTPConstants.MC_HTTP_SERVLETRESPONSE,
> response);
> +        msgContext.setProperty(HTTPConstants.MC_HTTP_SERVLETCONTEXT,
> getServletContext());
>
>         //setting the RequestResponseTransport object
>         msgContext.setProperty(RequestResponseTransport.TRANSPORT_CONTROL,
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-cvs-help@ws.apache.org
>
>


-- 
Saminda Abeyruwan

Senior Software Engineer
WSO2 Inc. - www.wso2.org

------=_Part_16820_87598.1207563666359
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi, <br><br>Is there a particular reason to add the line. <br><br>msgContext.setProperty(HTTPCon<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
stants.MC_HTTP_SERVLETCONTEXT, getServletContext());</blockquote><div><br>You will be able to access the context from http servlet request object. <br><br>Beside the prior added line will break some of the existing production code. <br>
<br>getServletContext() will work properly, IFF the user&#39;s servlet inherit the init method or if over-rides, it should called the parent init method. <br><br>In AxisServlet, yes it dose over-rides the init method and calls the parent init. <br>
<br>But those of us who have extended AxisServlet to work with, where over-rides the init method&nbsp; to intialize the AxisConfiguration the way our production system wants&nbsp; does not call the parents (AxisServlet) init method. <br>
<br>ex: <br>public class MyServlet extends AxisServlet {<br>&nbsp;&nbsp;&nbsp; ... <br>&nbsp;&nbsp; public void init(ServletConfig config) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; // my way of initializing axisconfiguration and listeners rather using parent <br>&nbsp;&nbsp;&nbsp;&nbsp; // init, but inheriting parents do* from AxisServlet. <br>
&nbsp; }<br><br>}<br><br>We used AxisServlet as show above for quite a long&nbsp; time. <br><br>I&#39;m afraid the prior line of code&nbsp; has broken the backward compatibility of re-using AxisServlet in production environments. <br><br>
Thus, the correct way is to obtain the servlet context from request, rather setting the property. <br><br>Thus, I would humbly ask to revert the commit to preserve backward compatibility. <br><br>Thank you!<br><br>Saminda<br>
</div><br><br><br><br><br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
 &nbsp; &nbsp; &nbsp; &nbsp; msgContext.setProperty(MessageContext.TRANSPORT_HEADERS, getTransportHeaders(request));<br>
 &nbsp; &nbsp; &nbsp; &nbsp; msgContext.setProperty(HTTPConstants.MC_HTTP_SERVLETREQUEST, request);<br>
 &nbsp; &nbsp; &nbsp; &nbsp; msgContext.setProperty(HTTPConstants.MC_HTTP_SERVLETRESPONSE, response);<br>
+ &nbsp; &nbsp; &nbsp; &nbsp;msgContext.setProperty(HTTPConstants.MC_HTTP_SERVLETCONTEXT, getServletContext());<br>
<br>
 &nbsp; &nbsp; &nbsp; &nbsp; //setting the RequestResponseTransport object<br>
 &nbsp; &nbsp; &nbsp; &nbsp; msgContext.setProperty(RequestResponseTransport.TRANSPORT_CONTROL,<br>
<br>
<br>
<br>
---------------------------------------------------------------------<br>
To unsubscribe, e-mail: <a href="mailto:axis-cvs-unsubscribe@ws.apache.org">axis-cvs-unsubscribe@ws.apache.org</a><br>
For additional commands, e-mail: <a href="mailto:axis-cvs-help@ws.apache.org">axis-cvs-help@ws.apache.org</a><br>
<br>
</blockquote></div><br><br clear="all"><br>-- <br>Saminda Abeyruwan<br><br>Senior Software Engineer<br>WSO2 Inc. - <a href="http://www.wso2.org">www.wso2.org</a>

------=_Part_16820_87598.1207563666359--