Return-Path: Delivered-To: apmail-ws-axis-dev-archive@www.apache.org Received: (qmail 59268 invoked from network); 17 Jan 2008 15:33:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 17 Jan 2008 15:33:59 -0000 Received: (qmail 74430 invoked by uid 500); 17 Jan 2008 15:33:47 -0000 Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org Received: (qmail 74391 invoked by uid 500); 17 Jan 2008 15:33:47 -0000 Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@ws.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list axis-dev@ws.apache.org Received: (qmail 74380 invoked by uid 99); 17 Jan 2008 15:33:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jan 2008 07:33:47 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 Jan 2008 15:33:41 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D27CE714274 for ; Thu, 17 Jan 2008 07:33:33 -0800 (PST) Message-ID: <13115446.1200584013833.JavaMail.jira@brutus> Date: Thu, 17 Jan 2008 07:33:33 -0800 (PST) From: "Rich Scheuerle (JIRA)" To: axis-dev@ws.apache.org Subject: [jira] Commented: (AXIS2-3457) Incorrect Exception in WSDL11ToAxisServiceBuilder In-Reply-To: <10848774.1200579873828.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/AXIS2-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559957#action_12559957 ] Rich Scheuerle commented on AXIS2-3457: --------------------------------------- Here is a snippet of the code that I will add to addPartToElement: String bindingOperationName = boe.getBindingOperation().getName(); String partName = part.getName(); if (boe.isRPC()) { // see the basic profile 4.4.1 for rpc-literal. // messages parts can have only types throw new WSDLProcessingException( "The binding operation " + bindingOperationName + " is RPC/literal. " + "The message parts for this operation must use the type " + "attribute as specificed by " + "WS-I Basic Profile specification (4.4.1). Message part, " + partName + ", violates" + "this rule. Please remove the element attribute " + "and use the type attribute."); } else { // Don't add this part if (log.isDebugEnabled()) { log.debug("The binding operation " + bindingOperationName + " references message part " + partName + ". This part does not use the " + "type attribute, so a wrappering element is not added."); } } > Incorrect Exception in WSDL11ToAxisServiceBuilder > ------------------------------------------------- > > Key: AXIS2-3457 > URL: https://issues.apache.org/jira/browse/AXIS2-3457 > Project: Axis 2.0 (Axis2) > Issue Type: Bug > Reporter: Rich Scheuerle > Assignee: Rich Scheuerle > > Background > WSDL11ToAxisServiceBuilder contains code to produce schema "wrapper" code for selected BindingOperations (i.e. RPC literal bindings). > > Problem: > I have a WSDL with several bindings, one of them is an HTTP Binding. The current code determines that its BindingOperations require wrappering, but > during the schema generation it throws the following error because it incorrectly assumes that the BindingOperation is RPC/literal. > org.apache.axis2.description.WSDL11ToAxisServiceBuilder populateService RPC-literal type message part Body should have a type attribute > Proposed Solution: > I have just started working on this issue. My thought is to introduce a private inner class BindingOperationEntry. The BindingOperationEntry will contain the BindingOperation and information about the BindingOperation (i.e. isRPC()). > The findWrappableBindingOperations(Binding binding) method will be changed to return a List of BindingOperationEntry instead of List of BindingOperation. Later processing can then easily distinguish between RPC and HTTP usage. > In addition, I am going to upgrade the exception message (which confused the user) and add some additional trace. > This solution has minimal impact on the existing structure of WSDL11ToAxisServiceBuilder, which is why I pursuing this approach. > Comments ? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org For additional commands, e-mail: axis-dev-help@ws.apache.org