Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: axis-dev@ws.apache.org
Received-SPF: pass (athena.apache.org: domain of amilasuriarachchi@gmail.com
 designates 209.85.198.188 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:mime-version:content-type;
        b=n488XaGug8dHMfztdfww07cdAdHkm+32fSXIrx78zjntXVIVM29AkHRzKfPI4ZyTHfqa2aM4ELDTdbUWaFd4oEqkB/X+/aoEhBkTY/TzKnM4CLENdPu+VSRi6mQZ/E744GWJmU1OgRriVw0QJpT3fWuaNfJ/s8cohmEdPGyS5Xw=
Message-ID: <60708f4b0712182030r33b0957cifc28f6ad7a5066a3@mail.gmail.com>
Date: Wed, 19 Dec 2007 10:00:40 +0530
From: "Amila Suriarachchi" <amilasuriarachchi@gmail.com>
To: axis-dev@ws.apache.org
Subject: [Axis2] Dispatch order
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_14339_1845488.1198038640717"

------=_Part_14339_1845488.1198038640717
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

hi all,

1. Here is a code segment found in the org.apache.axis2.engine.DispatchPhase
checkPostConditions method.

if (operation == null &&
                JavaUtils.isTrue(service.getParameterValue(
AxisService.SUPPORT_SINGLE_OP))) {
            Iterator ops = service.getOperations();
            // If there's exactly one, that's the one we want.  If there's
more, forget it.
            if (ops.hasNext()) {
                operation = (AxisOperation)ops.next();
                if (ops.hasNext()) {
                    operation = null;
                }
            }
            msgContext.setAxisOperation(operation);
        }

What it basically doing is that dispatch the operation if the
AxisService.SUPPORT_SINGLE_OP parameter is set and
there is only one operation on it.
Isn't this dispatcher supposed to run just after service being dispatched?
i.e as the first dispatcher of the Tranport phase.

Think about the scenario where this operation is engaged security. in this
case it should dispatched before the security.

I think any dispatcher which is possible to run before the security should
run before it.

2. RequestURIBasedDispatcher and SOAPActionBasedDispatcher are both in
Transport and Dispatch phases.
Is there any reason for this? or is it an obsolete code to keep this in
Dispatch phase?

Shall I do the above changes?

thanks,
Amila.


-- 
Amila Suriarachchi,
WSO2 Inc.

------=_Part_14339_1845488.1198038640717
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

hi all,<br><br>1. Here is a code segment found in the org.apache.axis2.engine.DispatchPhase<br>checkPostConditions method. <br><br>if (operation == null &amp;&amp;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; JavaUtils.isTrue(service.getParameterValue
(AxisService.SUPPORT_SINGLE_OP))) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; Iterator ops = service.getOperations();<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; // If there&#39;s exactly one, that&#39;s the one we want.&nbsp; If there&#39;s more, forget it.<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (ops.hasNext
()) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; operation = (AxisOperation)ops.next();<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; if (ops.hasNext()) {<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; operation = null;<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; msgContext.setAxisOperation
(operation);<br>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; }<br><br>What it basically doing is that dispatch the operation if the AxisService.SUPPORT_SINGLE_OP parameter is set and <br>there is only one operation on it. <br>Isn&#39;t this dispatcher supposed to run just after service being dispatched? 
i.e as the first dispatcher of the Tranport phase.<br><br>Think about the scenario where this operation is engaged security. in this case it should dispatched before the security.<br><br>I think any dispatcher which is possible to run before the security should run before it.
<br><br>2. RequestURIBasedDispatcher and SOAPActionBasedDispatcher are both in Transport and Dispatch phases.<br>Is there any reason for this? or is it an obsolete code to keep this in Dispatch phase?<br><br>Shall I do the above changes?
<br><br>thanks,<br>Amila.<br><br><br><br clear="all"><br>-- <br>Amila Suriarachchi,<br>WSO2 Inc.

------=_Part_14339_1845488.1198038640717--