Return-Path: 
 <axis-dev-return-66162-apmail-ws-axis-dev-archive=ws.apache.org@ws.apache.org>
Delivered-To: apmail-ws-axis-dev-archive@www.apache.org
Received: (qmail 15322 invoked from network); 18 Sep 2007 05:06:08 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 18 Sep 2007 05:06:08 -0000
Received: (qmail 76369 invoked by uid 500); 18 Sep 2007 05:05:59 -0000
Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org
Received: (qmail 76310 invoked by uid 500); 18 Sep 2007 05:05:59 -0000
Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: axis-dev@ws.apache.org
list-help: <mailto:axis-dev-help@ws.apache.org>
list-unsubscribe: <mailto:axis-dev-unsubscribe@ws.apache.org>
List-Post: <mailto:axis-dev@ws.apache.org>
List-Id: <axis-dev.ws.apache.org>
Delivered-To: mailing list axis-dev@ws.apache.org
Received: (qmail 76299 invoked by uid 99); 18 Sep 2007 05:05:58 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Sep 2007 22:05:58 -0700
X-ASF-Spam-Status: No, hits=-100.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Sep 2007 05:07:58 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id D412A714201
	for <axis-dev@ws.apache.org>; Mon, 17 Sep 2007 22:05:43 -0700 (PDT)
Message-ID: <14916033.1190091943865.JavaMail.jira@brutus>
Date: Mon, 17 Sep 2007 22:05:43 -0700 (PDT)
From: "Amila Chinthaka Suriarachchi (JIRA)" <jira@apache.org>
To: axis-dev@ws.apache.org
Subject: [jira] Commented: (AXIS2-3206) Wrong java code generation with adb
 for data type boolean
In-Reply-To: <14294512.1190020232232.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/AXIS2-3206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528250 ] 

Amila Chinthaka Suriarachchi commented on AXIS2-3206:
-----------------------------------------------------

this occurs if you have given a pattern facet for a simple type restricting boolean.

i.e
<simpleType name="test">
   <restriction base="xs:boolean>
          <pattern value=""/>
   </restriction>
</simpleType>

So what you basicaly saying is defining a pattern facet in a schema for boolean is incorrect. I am not sure about this but I think once it is given adding that restriction is correct. 
eg. if some one expects only true values  he can restric it by using this pattern.

> Wrong java code generation with adb for data type boolean
> ---------------------------------------------------------
>
>                 Key: AXIS2-3206
>                 URL: https://issues.apache.org/jira/browse/AXIS2-3206
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: adb
>    Affects Versions: 1.3, 1.2
>         Environment: Windows XP, Java 1.4.2
>            Reporter: Heinz Zerbes
>
> Java code generation with adb generates wrong code in case of data type boolean. This problem occures for example in 
> setMustUnderstand_type0(boolean param); The generated code is generic (the same for all data types). Unfortunatelly boolean does not fit into this generation pattern(instead of checking "true|false" "0|1" ist checked). Also for boolean it makes no sense to check the data type, because the java compiler does it anyway. 
> The problem is located in ADBBeanTemplate.xsl: 
> 					<xsl:choose>
> 						<xsl:when test="(@patternFacet)">
>                                                   if (java.lang.String.valueOf(param).matches("<xsl:value-of select="$patternFacet"/>")) {
>                                                        this.<xsl:value-of select="$varName"/>=param; }
>                                                  else {
>                                                      throw new java.lang.RuntimeException(); }
>                                                 ......
> For type==boolean it should be:
> 					<xsl:choose>
> 						<xsl:when test="(@patternFacet)">
> 	 					<xsl:choose>
> 						  <xsl:when test="$propertyType='boolean'">
>                                                   this.<xsl:value-of select="$varName"/>=param;
> 										</xsl:when
> 						<xsl:otherwise>
>                                                   if (java.lang.String.valueOf(param).matches("<xsl:value-of select="$patternFacet"/>")) {
>                                                        this.<xsl:value-of select="$varName"/>=param; }
>                                                  else {
>                                                      throw new java.lang.RuntimeException(); }
> 						</xsl:otherwise>
> 					</xsl:choose>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org