axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Glen Daniels <g...@thoughtcraft.com>
Subject [axis2] Re: svn commit: r543436 - /webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/mail/SimpleMailListener.java
Date Thu, 19 Jul 2007 21:26:59 GMT

Hi Amila!

So am I to understand there isn't a test which confirms that the mail 
transport works?  If not, we should add one....

--Glen

Amila Suriarachchi wrote:
> I reverted this change since mail transport does not work after this change.
> why you did this change? please check the senario which you tried to fix.
> 
> Amila.
> 
> On 6/1/07, * deepal@apache.org <mailto:deepal@apache.org>* 
> <deepal@apache.org <mailto:deepal@apache.org>> wrote:
> 
>     Author: deepal
>     Date: Fri Jun  1 02:09:21 2007
>     New Revision: 543436
> 
>     URL: http://svn.apache.org/viewvc?view=rev&rev=543436
>     <http://svn.apache.org/viewvc?view=rev&rev=543436>
>     Log:
>     fixing incorrect logic (no need to go thru SynchronousMailListener ,
>     if we find the corresponding  operation context)
> 
>     Modified:
>         webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/mail/SimpleMailListener.java
> 
>     Modified:
>     webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/mail/SimpleMailListener.java
> 
>     URL:
>     http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/mail/SimpleMailListener.java?view=diff&rev=543436&r1=543435&r2=543436
>     <http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/mail/SimpleMailListener.java?view=diff&rev=543436&r1=543435&r2=543436>
>     ==============================================================================
>     ---
>     webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/mail/SimpleMailListener.java
>     (original)
>     +++
>     webservices/axis2/trunk/java/modules/kernel/src/org/apache/axis2/transport/mail/SimpleMailListener.java
>     Fri Jun  1 02:09:21 2007
>     @@ -382,6 +382,7 @@
>                          msgContext.setAxisMessage(inMessage);
>                          opContext.addMessageContext(msgContext);
>                         
>     msgContext.setServiceContext(opContext.getServiceContext ());
>     +                    return true;
>                      }
>                  }
>              }
>     @@ -391,10 +392,9 @@
>                  SynchronousMailListener listener =
>     (SynchronousMailListener) callBackTable.get(messageID);
>                  if(listener!=null){
>                      listener.setInMessageContext(msgContext);
>     -                return false;
>                  }
>              }
>     -        return true;
>     +        return false;
>          }
> 
>          private void buildSOAPEnvelope(MimeMessage msg, MessageContext
>     msgContext)
> 
> 
> 
>     ---------------------------------------------------------------------
>     To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
>     <mailto:axis-cvs-unsubscribe@ws.apache.org>
>     For additional commands, e-mail: axis-cvs-help@ws.apache.org
>     <mailto:axis-cvs-help@ws.apache.org>
> 
> 
> 
> 
> -- 
> Amila Suriarachchi,
> WSO2 Inc.

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Mime
View raw message