axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michele Mazzucco (JIRA)" <j...@apache.org>
Subject [jira] Commented: (AXIS2-2595) HttpServiceProcessor needs hashCode and equals
Date Fri, 22 Jun 2007 22:01:26 GMT

    [ https://issues.apache.org/jira/browse/AXIS2-2595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507529
] 

Michele Mazzucco commented on AXIS2-2595:
-----------------------------------------

Dims,

they should be ok. The last time you changed those classes it was 09 April. Or you want me
to make the proposed changes in DefaultHttpConnectionManager as well (i.e. remove the list)?


Michele

> HttpServiceProcessor needs hashCode and equals
> ----------------------------------------------
>
>                 Key: AXIS2-2595
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2595
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: nightly
>         Environment: all
>            Reporter: Michele Mazzucco
>            Assignee: Deepal Jayasinghe
>         Attachments: DefaultHttpConnectionManager.patch, HttpServiceProcessor.patch
>
>
> In HttpServiceProcessor:
> - I've introduced an unique identifier to provide the equals and hashCode
> methods. The equals method is needed because HttpServiceProcessor instances are
> stored in a LinkedList in DefaultHttpConnectionManager.
> - The destroy method closes the connections, instead of calling shutdown
> In DefaultHttpConnectionManager:
> - I don't think it is necessary to store the processors in a linked list and use
> a callback when they are done to remove them from the list because the executor
> has a working queue where waiting jobs are put.
> - Instead of an Executor, I would use an ExecutorService (created in the
> constructor, now passed as reference), which can be stopped in the shutdown
> method. At present, instead, is would still possible to submit requests (i.e. by
> calling process()) after calling the shutdown (and what would happen?)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Mime
View raw message