Return-Path: Delivered-To: apmail-ws-axis-dev-archive@www.apache.org Received: (qmail 76480 invoked from network); 29 May 2007 05:48:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 29 May 2007 05:48:32 -0000 Received: (qmail 69959 invoked by uid 500); 29 May 2007 05:48:30 -0000 Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org Received: (qmail 69892 invoked by uid 500); 29 May 2007 05:48:29 -0000 Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@ws.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list axis-dev@ws.apache.org Received: (qmail 69881 invoked by uid 99); 29 May 2007 05:48:29 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 May 2007 22:48:29 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [209.68.5.9] (HELO relay00.pair.com) (209.68.5.9) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 28 May 2007 22:48:24 -0700 Received: (qmail 73685 invoked from network); 29 May 2007 05:48:02 -0000 Received: from 124.43.193.122 (HELO ?127.0.0.1?) (124.43.193.122) by relay00.pair.com with SMTP; 29 May 2007 05:48:02 -0000 X-pair-Authenticated: 124.43.193.122 Message-ID: <465BBE8E.2090108@opensource.lk> Date: Tue, 29 May 2007 11:17:58 +0530 From: Deepal Jayasinghe User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: axis-dev@ws.apache.org Subject: Re: Axis2 Architecture problems. ... not any more ;) References: <60708f4b0705280730y70802142jab0894b693781444@mail.gmail.com> <60708f4b0705280744t148e463fxe8e0745537083df0@mail.gmail.com> <465B49E8.2040203@opensource.lk> <465B9BB4.6080308@gmail.com> In-Reply-To: <465B9BB4.6080308@gmail.com> X-Enigmail-Version: 0.95.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Samisa Abeysinghe wrote: > Ajith Ranabahu wrote: >> >> However we may be able to improve a bit of the code :) Since the >> handlers are stateless replicating them would not mean anything >> (shouldn't make a difference). > +1. I too agree. >> Should we able to create a read-only >> List implementation where only one of the handler instances exist in >> the engine ? > Looking at the logic: > ArrayList outPhases = new ArrayList(); > outPhases.addAll((ArrayList) executionChain.clone()); > outPhases.addAll((ArrayList) msgContext.getConfigurationContext() > .getAxisConfiguration().getGlobalOutPhases().clone()); > msgContext.setExecutionChain(outPhases); > > It does not look like we do any changes to the list after cloning. > Hence would be better off to drop cloning. Yes, you can see this code at the sending path. There we get the handler chain from operation and merge that with the global out chain. But in the receiving path logic is other way round , first we invoke the global chain and after dispatch phase we merged operation specific handler chain. Thanks Deepal --------------------------------------------------------------------- To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org For additional commands, e-mail: axis-dev-help@ws.apache.org