Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: axis-dev@ws.apache.org
Received-SPF: pass (herse.apache.org: local policy)
Message-ID: <463F3ABB.7020201@thoughtcraft.com>
Date: Mon, 07 May 2007 10:42:03 -0400
User-Agent: Thunderbird 1.5.0.10 (Windows/20070221)
MIME-Version: 1.0
To: axis-dev@ws.apache.org
Subject: Re: [Axis2] Engaging modules at runtime.
References: <aa8fdb10705070040l1ee86dfau2724ffb6454486fe@mail.gmail.com>
	<463F00C9.10309@wso2.com>
In-Reply-To: <463F00C9.10309@wso2.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
From: Glen Daniels <glen@thoughtcraft.com>

Hi Saminda!

sumedha rubasinghe wrote:
> forwarding with correct prefix...
> 
> Saminda Abeyruwan wrote:
>> Hi,
>>
>> AxisConfiguration has the following methods,
>>
>>   public void engageModule(AxisModule axisModule, AxisConfiguration 
>> axisConfig)
>>             throws AxisFault {
>>         engageModule(axisModule);
>>     }   --- > [1]
>>
>>     private void engageModule(AxisModule module) throws AxisFault 
>> {...} --> [2]
>>
>> What is the purpose of [1]. Wouldn't it better to modify the access 
>> modifier of [2] to *public* and remove [1].

+1!

However, this is a slightly more complicated problem.  The 
engageModule(AxisModule, AxisConfiguration) API comes from 
AxisDescription, so we'd need to change THAT one to really do this. 
This is exactly what I think we should do, since all AxisDescription 
objects should be able to find their AxisConfiguration without any 
problem - therefore they shouldn't need to have it passed in (and in 
fact even leaving the API the option of passing it means that it's 
possible for people to screw up and pass a *different* AxisConfiguration 
than the one the current object belongs to... good APIs should protect 
against things like this).

So I'd propose we remove the first version, and refactor the second 
version up to AxisDescription.

--Glen

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org