axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Saminda Abeyruwan" <samin...@gmail.com>
Subject [Axis2] Inconsistencies in getting engaged modules
Date Fri, 04 May 2007 09:14:51 GMT
Hi Devs,

We've came across the following inconsistencies when calling
getEngagedModules() method, in
1. AxisOperation
2. AxisService
3. AxisServiceGroup

AxisOperation has,
public Collection getEngagedModules() {...} --> This will give an instance
of ArrayList which has AxisModule  objects.

AxisService has,
public Collection getEngagedModules() {...} --> This will give an instance
of ArrayList which has String objects.

String objects are the names of engaged modules.

AxisServiceGroup has,
public ArrayList getEngagedModules() {...} --> This will give an instance of
ArrayList which has String objects.

String objects are the names of engaged modules.

This will lead to difficulties when working with them.

IMHO  getEngagedModules() should be a method an abstract in AxisDescription;


public Collection getEngagedModules()

or

public List getEngagedModules(),

and should return either AxisModule or Name of the module as String. IMHO
AxisModule would be preferable. Thus, others that extend from AxisDecription
will be benefited too.

Please be kind enough to  express your thoughts on  prior.

Thank you

Saminda





-- 
Saminda Abeyruwan

Software Engineer
WSO2 Inc. - www.wso2.org

Mime
View raw message