axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sam...@apache.org
Subject svn commit: r532209 - in /webservices/axis2/trunk/c: axiom/src/attachments/ axiom/src/om/ axiom/src/soap/ samples/server/Calculator/ samples/server/math/ samples/server/sg_math/ src/core/clientapi/ src/core/context/ src/core/deployment/ src/core/engine...
Date Wed, 25 Apr 2007 06:02:48 GMT
Author: samisa
Date: Tue Apr 24 23:02:46 2007
New Revision: 532209

URL: http://svn.apache.org/viewvc?view=rev&rev=532209
Log:
Removed some outdated TODO notes from code 

Modified:
    webservices/axis2/trunk/c/axiom/src/attachments/data_handler.c
    webservices/axis2/trunk/c/axiom/src/attachments/mime_body_part.c
    webservices/axis2/trunk/c/axiom/src/om/om_element.c
    webservices/axis2/trunk/c/axiom/src/soap/soap11_builder_helper.c
    webservices/axis2/trunk/c/axiom/src/soap/soap_envelope.c
    webservices/axis2/trunk/c/samples/server/Calculator/calc_skeleton.c
    webservices/axis2/trunk/c/samples/server/math/math_skeleton.c
    webservices/axis2/trunk/c/samples/server/sg_math/add_skeleton.c
    webservices/axis2/trunk/c/samples/server/sg_math/div_skeleton.c
    webservices/axis2/trunk/c/samples/server/sg_math/mul_skeleton.c
    webservices/axis2/trunk/c/samples/server/sg_math/sub_skeleton.c
    webservices/axis2/trunk/c/src/core/clientapi/op_client.c
    webservices/axis2/trunk/c/src/core/clientapi/options.c
    webservices/axis2/trunk/c/src/core/clientapi/svc_client.c
    webservices/axis2/trunk/c/src/core/context/op_ctx.c
    webservices/axis2/trunk/c/src/core/deployment/conf_builder.c
    webservices/axis2/trunk/c/src/core/deployment/dep_engine.c
    webservices/axis2/trunk/c/src/core/deployment/desc_builder.c
    webservices/axis2/trunk/c/src/core/deployment/module_builder.c
    webservices/axis2/trunk/c/src/core/deployment/repos_listener.c
    webservices/axis2/trunk/c/src/core/deployment/svc_builder.c
    webservices/axis2/trunk/c/src/core/deployment/ws_info_list.c
    webservices/axis2/trunk/c/src/core/engine/engine.c
    webservices/axis2/trunk/c/src/core/engine/soap_action_disp.c
    webservices/axis2/trunk/c/src/core/phaseresolver/phase_resolver.c
    webservices/axis2/trunk/c/src/core/transport/http/common/http_response_writer.c
    webservices/axis2/trunk/c/src/core/transport/http/common/http_simple_request.c
    webservices/axis2/trunk/c/src/core/transport/http/common/http_worker.c
    webservices/axis2/trunk/c/src/core/transport/http/receiver/http_svr_thread.c
    webservices/axis2/trunk/c/src/core/transport/http/sender/http_sender.c
    webservices/axis2/trunk/c/src/core/transport/http/sender/http_transport_sender.c
    webservices/axis2/trunk/c/src/core/transport/http/sender/ssl/ssl_stream.c
    webservices/axis2/trunk/c/src/core/transport/http/sender/ssl/ssl_utils.c
    webservices/axis2/trunk/c/src/core/transport/http/server/apache2/apache2_stream.c
    webservices/axis2/trunk/c/src/core/transport/http/util/http_transport_utils.c
    webservices/axis2/trunk/c/src/modules/mod_addr/addr_in_handler.c
    webservices/axis2/trunk/c/src/modules/mod_addr/mod_addr.c
    webservices/axis2/trunk/c/util/src/platforms/windows/thread_mutex_windows.c

Modified: webservices/axis2/trunk/c/axiom/src/attachments/data_handler.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/axiom/src/attachments/data_handler.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/axiom/src/attachments/data_handler.c (original)
+++ webservices/axis2/trunk/c/axiom/src/attachments/data_handler.c Tue Apr 24 23:02:46 2007
@@ -121,7 +121,6 @@
 axiom_data_handler_get_input_stream(axiom_data_handler_t *data_handler, 
     const axutil_env_t *env)
 {
-    /*@TODO implement the following*/
     return (axis2_byte_t *)"";
 }
 
@@ -189,9 +188,8 @@
             count = fread(read_stream, 1, read_stream_size, f);
             if (ferror(f) != 0)
             {
-                /*TODO : need to set the correct error code */
                 AXIS2_ERROR_SET(env->error, 
-		    AXIS2_ERROR_NO_MEMORY, AXIS2_FAILURE);
+                    AXIS2_ERROR_NO_MEMORY, AXIS2_FAILURE);
                 if (byte_stream)
                 {
                     AXIS2_FREE(env->allocator, byte_stream);
@@ -309,7 +307,6 @@
 
         if (ferror(f) != 0)
         {
-            /*TODO : need to set the correct error code */
             return AXIS2_FAILURE;
         }
         fflush(f);

Modified: webservices/axis2/trunk/c/axiom/src/attachments/mime_body_part.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/axiom/src/attachments/mime_body_part.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/axiom/src/attachments/mime_body_part.c (original)
+++ webservices/axis2/trunk/c/axiom/src/attachments/mime_body_part.c Tue Apr 24 23:02:46 2007
@@ -172,10 +172,9 @@
         header_str_size = axutil_strlen(header_str);
     }
 
-    /* TODO encoding needs to be done, we only support binary as of now,
-       Java supports "base64", "uuencode", "x-uuencode", "x-uue", 
-       "quoted-printable" 
-    */
+    /* TODO: We only support binary as of now,
+       Axis2/Java supports "base64", "uuencode", "x-uuencode", "x-uue", 
+       "quoted-printable" */
     if (mime_body_part->data_handler)
     {
         status = axiom_data_handler_read_from(mime_body_part->data_handler, env,
@@ -201,7 +200,6 @@
         }
         return AXIS2_FAILURE;
     }
-    /*TODO char2byte header_str */
     if (header_str)
     {
         memcpy(byte_stream, header_str, header_str_size);

Modified: webservices/axis2/trunk/c/axiom/src/om/om_element.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/axiom/src/om/om_element.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/axiom/src/om/om_element.c (original)
+++ webservices/axis2/trunk/c/axiom/src/om/om_element.c Tue Apr 24 23:02:46 2007
@@ -807,8 +807,7 @@
         ns = om_element->ns;
     }
     else
-    {   /* TODO need to change get_namespace and get_qname methods so
-            that default namespace is handled properly */
+    {   
         ns = axiom_element_get_default_namespace(
             om_element, env, ele_node);
 

Modified: webservices/axis2/trunk/c/axiom/src/soap/soap11_builder_helper.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/axiom/src/soap/soap11_builder_helper.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/axiom/src/soap/soap11_builder_helper.c (original)
+++ webservices/axis2/trunk/c/axiom/src/soap/soap11_builder_helper.c Tue Apr 24 23:02:46 2007
@@ -218,7 +218,6 @@
             if (!fault_text_node)
                 return AXIS2_FAILURE;
 
-            /* TODO process namespace data */
             axiom_stax_builder_set_lastnode(builder_helper->om_builder, env, fault_text_node);
 
             status = axiom_soap11_builder_helper_process_text(builder_helper, env);

Modified: webservices/axis2/trunk/c/axiom/src/soap/soap_envelope.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/axiom/src/soap/soap_envelope.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/axiom/src/soap/soap_envelope.c (original)
+++ webservices/axis2/trunk/c/axiom/src/soap/soap_envelope.c Tue Apr 24 23:02:46 2007
@@ -248,7 +248,6 @@
     axiom_namespace_t *ns = NULL;
     AXIS2_ENV_CHECK(env, NULL);
 
-    /* TODO : cache SOAP header and soap_envelope instead of looking them up?*/
     if (!soap_envelope->header)
         return NULL;
 
@@ -554,7 +553,7 @@
         ns_uri = AXIOM_SOAP12_SOAP_ENVELOPE_NAMESPACE_URI;
     }
     else
-    {   /** TODO set error */
+    {   
         return AXIS2_FAILURE;
     }
 

Modified: webservices/axis2/trunk/c/samples/server/Calculator/calc_skeleton.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/samples/server/Calculator/calc_skeleton.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/samples/server/Calculator/calc_skeleton.c (original)
+++ webservices/axis2/trunk/c/samples/server/Calculator/calc_skeleton.c Tue Apr 24 23:02:46
2007
@@ -122,7 +122,7 @@
 
     printf("Calculator service ERROR: invalid OM parameters in request\n");
 
-    /** TODO: return a SOAP fault here */
+    /** Note: return a SOAP fault here */
     return node;
 }
 
@@ -134,10 +134,6 @@
         const axutil_env_t *env)
 {
     *inst = axis2_calc_create(env);
-    /*if( *inst)
-    {
-        status = *inst->init();
-    }*/
     if (!(*inst))
     {
         return AXIS2_FAILURE;

Modified: webservices/axis2/trunk/c/samples/server/math/math_skeleton.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/samples/server/math/math_skeleton.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/samples/server/math/math_skeleton.c (original)
+++ webservices/axis2/trunk/c/samples/server/math/math_skeleton.c Tue Apr 24 23:02:46 2007
@@ -122,7 +122,7 @@
 
     printf("Math service ERROR: invalid OM parameters in request\n");
 
-    /** TODO: return a SOAP fault here */
+    /** Note: return a SOAP fault here */
     return node;
 }
 
@@ -134,10 +134,6 @@
         const axutil_env_t *env)
 {
     *inst = math_create(env);
-    /*if( *inst)
-    {
-        status = *inst->init();
-    }*/
     if (!(*inst))
     {
         return AXIS2_FAILURE;

Modified: webservices/axis2/trunk/c/samples/server/sg_math/add_skeleton.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/samples/server/sg_math/add_skeleton.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/samples/server/sg_math/add_skeleton.c (original)
+++ webservices/axis2/trunk/c/samples/server/sg_math/add_skeleton.c Tue Apr 24 23:02:46 2007
@@ -113,7 +113,7 @@
 
     printf("Math service ERROR: invalid OM parameters in request\n");
 
-    /** TODO: return a SOAP fault here */
+    /** Note: return a SOAP fault here */
     return node;
 }
 

Modified: webservices/axis2/trunk/c/samples/server/sg_math/div_skeleton.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/samples/server/sg_math/div_skeleton.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/samples/server/sg_math/div_skeleton.c (original)
+++ webservices/axis2/trunk/c/samples/server/sg_math/div_skeleton.c Tue Apr 24 23:02:46 2007
@@ -113,7 +113,7 @@
 
     printf("Math service ERROR: invalid OM parameters in request\n");
 
-    /** TODO: return a SOAP fault here */
+    /** Note: return a SOAP fault here */
     return node;
 }
 

Modified: webservices/axis2/trunk/c/samples/server/sg_math/mul_skeleton.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/samples/server/sg_math/mul_skeleton.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/samples/server/sg_math/mul_skeleton.c (original)
+++ webservices/axis2/trunk/c/samples/server/sg_math/mul_skeleton.c Tue Apr 24 23:02:46 2007
@@ -113,7 +113,7 @@
 
     printf("Math service ERROR: invalid OM parameters in request\n");
 
-    /** TODO: return a SOAP fault here */
+    /** Note: return a SOAP fault here */
     return node;
 }
 

Modified: webservices/axis2/trunk/c/samples/server/sg_math/sub_skeleton.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/samples/server/sg_math/sub_skeleton.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/samples/server/sg_math/sub_skeleton.c (original)
+++ webservices/axis2/trunk/c/samples/server/sg_math/sub_skeleton.c Tue Apr 24 23:02:46 2007
@@ -112,7 +112,7 @@
 
     printf("Math service ERROR: invalid OM parameters in request\n");
 
-    /** TODO: return a SOAP fault here */
+    /** Note: return a SOAP fault here */
     return node;
 }
 

Modified: webservices/axis2/trunk/c/src/core/clientapi/op_client.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/clientapi/op_client.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/clientapi/op_client.c (original)
+++ webservices/axis2/trunk/c/src/core/clientapi/op_client.c Tue Apr 24 23:02:46 2007
@@ -305,7 +305,6 @@
 
     if(op_client->completed)
     {
-        /**TODO:error completed*/
         return AXIS2_FAILURE;
     }
 
@@ -316,7 +315,6 @@
 
     if(!msg_ctx)
     {
-        /*TODO:error msg ctx is null*/
         return AXIS2_FAILURE;
     }
 
@@ -407,7 +405,6 @@
         AXIS2_CALLBACK_RECV_ADD_CALLBACK(op_client->callback_recv, env,
             axis2_msg_ctx_get_msg_id(msg_ctx, env),
             op_client->callback);
-        /* TODO: set up reply to */
          axis2_msg_ctx_set_op_ctx(msg_ctx, env, axis2_op_find_op_ctx(op, env,
                 msg_ctx, op_client->svc_ctx));
          axis2_msg_ctx_set_svc_ctx(msg_ctx, env, op_client->svc_ctx);

Modified: webservices/axis2/trunk/c/src/core/clientapi/options.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/clientapi/options.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/clientapi/options.c (original)
+++ webservices/axis2/trunk/c/src/core/clientapi/options.c Tue Apr 24 23:02:46 2007
@@ -553,7 +553,6 @@
 
     if (!(options->transport_out))
     {
-        /*TODO:error*/
         return AXIS2_FAILURE;
     }
     return AXIS2_SUCCESS;
@@ -603,10 +602,8 @@
     {
         if (sender_transport != receiver_transport)
         {
-            /*TODO:error*/
             return AXIS2_FAILURE;
         }
-        /*TODO: check the transport is either HTTP or TCP*/
     }
     else
     {

Modified: webservices/axis2/trunk/c/src/core/clientapi/svc_client.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/clientapi/svc_client.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/clientapi/svc_client.c (original)
+++ webservices/axis2/trunk/c/src/core/clientapi/svc_client.c Tue Apr 24 23:02:46 2007
@@ -156,9 +156,6 @@
     wsdl_path = axutil_strcat(env, repos_path, AXIS2_PATH_SEP_STR, "woden", NULL);
 
     svc_client->options = axis2_options_create(env);
-    /* TODO: this method should be moved out of core implementation
-    svc_client->svc = axis2_client_utils_create_axis2_svc(env, wsdl_uri,
-        wsdl_svc_qname, endpoint_name, wsdl_path, svc_client->options); */
     if (svc_client->svc)
     {
         axutil_hash_index_t *i = NULL;
@@ -886,7 +883,6 @@
 
     if (!op)
     {
-        /*TODO:error - svc does not have the operation*/
         return NULL;
     }
 
@@ -939,8 +935,6 @@
 {
     AXIS2_ENV_CHECK(env, AXIS2_FAILURE);
 
-    /*TODO:implement-issue - there's not get_own_endpoint_ref in svc_ctx*/
-
     return NULL;
 }
 
@@ -950,8 +944,6 @@
 {
     AXIS2_ENV_CHECK(env, AXIS2_FAILURE);
 
-    /*TODO:implement-issue - there's not get_target_endpoint_ref in svc_ctx*/
-
     return NULL;
 }
 
@@ -961,8 +953,6 @@
     axis2_endpoint_ref_t *target_endpoint_ref)
 {
     AXIS2_ENV_CHECK(env, AXIS2_FAILURE);
-
-    /*TODO:implement-issue - there's not set_my_epr in svc_ctx*/
 
     return AXIS2_FAILURE;
 }

Modified: webservices/axis2/trunk/c/src/core/context/op_ctx.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/context/op_ctx.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/context/op_ctx.c (original)
+++ webservices/axis2/trunk/c/src/core/context/op_ctx.c Tue Apr 24 23:02:46 2007
@@ -240,7 +240,6 @@
 
     if (out_msg_ctx && in_msg_ctx)
     {
-        /*TODO:error - completed*/
         axutil_thread_mutex_unlock(op_ctx->mutex);
         return AXIS2_FAILURE;
     }

Modified: webservices/axis2/trunk/c/src/core/deployment/conf_builder.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/deployment/conf_builder.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/deployment/conf_builder.c (original)
+++ webservices/axis2/trunk/c/src/core/deployment/conf_builder.c Tue Apr 24 23:02:46 2007
@@ -208,7 +208,7 @@
     {
         axis2_conf_builder_process_disp_order(conf_builder, env, disp_order_node);
         AXIS2_LOG_DEBUG(env->log, AXIS2_LOG_SI, "found the custom disptaching \
-            order and continue with that order");
+order and continue with that order");
     }
     else
     {
@@ -218,7 +218,7 @@
             return AXIS2_FAILURE;
         }
         AXIS2_LOG_DEBUG(env->log, AXIS2_LOG_SI, "no custom dispatching order \
-            found continue with default dispatcing order");
+found continue with default dispatching order");
     }
 
     /* Process Module refs */
@@ -267,7 +267,6 @@
             return AXIS2_FAILURE;
         }
     }
-    /* TODO processing Axis Storages */
 
     param = axutil_param_container_get_param(
         axis2_conf_get_param_container(conf_builder->conf, env), 
@@ -402,8 +401,6 @@
         dll_name =
             axutil_dll_desc_create_platform_specific_dll_name(dll_desc, env,
             class_name);
-        /* TODO
-         * set full dll path here instead of dll lib name only */
          axutil_dll_desc_set_name(dll_desc, env, dll_name);
          axutil_dll_desc_set_type(dll_desc, env, AXIS2_HANDLER_DLL);
         impl_info_param = axutil_param_create(env, class_name, NULL);
@@ -423,8 +420,7 @@
         handler_desc = axis2_handler_get_handler_desc(handler, env);
         axis2_handler_desc_add_param(handler_desc, env, impl_info_param);
 
-        /*disptachClas.getHandlerDesc().setParent(axisConfiguration); */
-         axis2_phase_add_handler_at(disp_phase, env, count, handler);
+        axis2_phase_add_handler_at(disp_phase, env, count, handler);
         count ++;
         qname_itr_has_next = axiom_children_qname_iterator_has_next(disps,
             env);

Modified: webservices/axis2/trunk/c/src/core/deployment/dep_engine.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/deployment/dep_engine.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/deployment/dep_engine.c (original)
+++ webservices/axis2/trunk/c/src/core/deployment/dep_engine.c Tue Apr 24 23:02:46 2007
@@ -612,15 +612,7 @@
     {
         return NULL;
     }
-    /*
-     * TODO
-    if (hot_deployment) 
-    {
-        start_search();
-    } 
-    else 
-    {
-    */
+
     if (dep_engine->repos_listener)
     {
         axis2_repos_listener_free(dep_engine->repos_listener, env);
@@ -852,7 +844,6 @@
     AXIS2_ENV_CHECK(env, AXIS2_FAILURE);
 
     in_phases = axis2_phases_info_get_in_phases(dep_engine->phases_info, env);
-    /* TODO condition checking should be otherway since null value can occur */
     if (in_phases)
     {
         phase0 = (axis2_char_t *) axutil_array_list_get(in_phases, env, 0);
@@ -1049,7 +1040,7 @@
     temp_path = axutil_stracat(env, module_folder_path, AXIS2_PATH_SEP_STR);
     dll_path = axutil_stracat(env, temp_path, dll_name);
     AXIS2_LOG_DEBUG(env->log, AXIS2_LOG_SI,
-        "axis2_dep_engine_load_module_dll; dll path is : %s", dll_path);
+        "axis2_dep_engine_load_module_dll: DLL path is : %s", dll_path);
     status =  axutil_dll_desc_set_name(dll_desc, env, dll_path);
     if (AXIS2_SUCCESS != status)
     {
@@ -1127,7 +1118,6 @@
     dll_name =
          axutil_dll_desc_create_platform_specific_dll_name(dll_desc, env,
              class_name);
-    /* TODO set fill dll path here instead of dll lib name only */
     axutil_dll_desc_set_name(dll_desc, env, dll_name);
     axutil_dll_desc_set_type(dll_desc, env, AXIS2_HANDLER_DLL);
     axutil_class_loader_init(env);

Modified: webservices/axis2/trunk/c/src/core/deployment/desc_builder.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/deployment/desc_builder.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/deployment/desc_builder.c (original)
+++ webservices/axis2/trunk/c/src/core/deployment/desc_builder.c Tue Apr 24 23:02:46 2007
@@ -688,15 +688,6 @@
             axiom_children_qname_iterator_next(params, env);
         param_element = axiom_node_get_data_element(param_node, env);
         param = axutil_param_create(env, NULL, NULL);
-        /* TODO Setting param_element. Do not set element like following.
-         * break it and set 
-         */
-        /*status = AXIS2_PARAM_SET_ELEMENT(param, env, param_node);
-        if(AXIS2_SUCCESS != status)
-        {
-            axutil_param_free(param, env);
-            return status;
-        }*/
 
         /* Setting paramter name */
         att_qname = axutil_qname_create(env, AXIS2_ATTNAME, NULL, NULL);

Modified: webservices/axis2/trunk/c/src/core/deployment/module_builder.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/deployment/module_builder.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/deployment/module_builder.c (original)
+++ webservices/axis2/trunk/c/src/core/deployment/module_builder.c Tue Apr 24 23:02:46 2007
@@ -403,9 +403,6 @@
         }
         else
         {
-            /* TODO
-             * We don't have a operation constructor taking mepURL as argument.
-             * do we need this? */
             op_desc = axis2_op_create_from_module(env);
         }
 

Modified: webservices/axis2/trunk/c/src/core/deployment/repos_listener.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/deployment/repos_listener.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/deployment/repos_listener.c (original)
+++ webservices/axis2/trunk/c/src/core/deployment/repos_listener.c Tue Apr 24 23:02:46 2007
@@ -195,7 +195,6 @@
      * there are no services to load
      */
     axis2_repos_listener_check_svcs(repos_listener, env);
-    /* TODO uncomment this when hot update done */
     return axis2_repos_listener_update(repos_listener, env);
 }
 

Modified: webservices/axis2/trunk/c/src/core/deployment/svc_builder.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/deployment/svc_builder.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/deployment/svc_builder.c (original)
+++ webservices/axis2/trunk/c/src/core/deployment/svc_builder.c Tue Apr 24 23:02:46 2007
@@ -205,11 +205,6 @@
     }
 
     /* process service description */
-    /* TODO this code is changed in new version of axis2. Until that logic
-     * is incorporated I comment out this part and add my own logic to set svc
-     * name
-     */
-	 /* -------------------------service description-------------------- */
     qdesc = axutil_qname_create(env, AXIS2_DESCRIPTION, NULL, NULL);
     desc_element = axiom_element_get_first_child_with_qname(svc_element, env,
         qdesc, svc_node, &desc_node);
@@ -247,9 +242,6 @@
         axis2_svc_set_svc_wsdl_path(svc_builder->svc, env, wsdl_path);
     }
 
-
-	 /* --------------------services description end -------------------- */
-    /* my logic to get set service name */
     qattname = axutil_qname_create(env, AXIS2_ATTNAME, NULL, NULL);
     name_attr = axiom_element_get_attribute(svc_element, env, qattname);
     svc_name = axiom_attribute_get_value(name_attr, env);
@@ -283,7 +275,7 @@
     svc_folder_path =  axutil_file_get_path(svc_folder, env);
     dll_path = axutil_strcat(env, svc_folder_path, AXIS2_PATH_SEP_STR,
         svc_dll_name, NULL);
-    AXIS2_LOG_DEBUG(env->log, AXIS2_LOG_SI, "dll path is : %s", dll_path);
+    AXIS2_LOG_DEBUG(env->log, AXIS2_LOG_SI, "DLL path is : %s", dll_path);
     status =  axutil_dll_desc_set_name(dll_desc, env, dll_path);
     if (AXIS2_SUCCESS != status)
     {
@@ -302,7 +294,6 @@
         axutil_dll_desc_free(dll_desc, env);
         return status;
     }
-    /* end of my logic */
     /* processing service wide modules which required to engage globally */
     qmodulest = axutil_qname_create(env, AXIS2_MODULEST, NULL, NULL);
     module_refs = axiom_element_get_children_with_qname(svc_element, env,
@@ -434,22 +425,19 @@
         op_mep_att = axiom_element_get_attribute(op_element, env, qmep);
         axutil_qname_free(qmep, env);
         qmep = NULL;
-        if (op_mep_att)
-        {
-            mep_url = axiom_attribute_get_value(op_mep_att, env);
-            /*
-            TODO value has to be validate
-            TODO
-             op_descrip.setMessageExchangePattern(mep);
-            */
-        }
         op_name = axiom_attribute_get_value(op_name_att, env);
         qopname = axutil_qname_create(env, op_name, NULL, NULL);
         op_desc = axis2_op_create(env);
-        if(mep_url)
+
+        if (op_mep_att)
         {
-            axis2_op_set_msg_exchange_pattern(op_desc, env, mep_url);
+            mep_url = axiom_attribute_get_value(op_mep_att, env);
+            if(mep_url)
+            {
+                axis2_op_set_msg_exchange_pattern(op_desc, env, mep_url);
+            }
         }
+
         axis2_op_set_qname(op_desc, env, qopname);
 
         axutil_qname_free(qopname, env);

Modified: webservices/axis2/trunk/c/src/core/deployment/ws_info_list.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/deployment/ws_info_list.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/deployment/ws_info_list.c (original)
+++ webservices/axis2/trunk/c/src/core/deployment/ws_info_list.c Tue Apr 24 23:02:46 2007
@@ -393,14 +393,6 @@
     {
         return AXIS2_FAILURE;
     }
-    /* TODO uncomment when hot deployment supported */
-    /*
-    if(AXIS2_TRUE == axis2_dep_engine_is_hot_update(ws_info_list->deployer, 
-        env))
-    {
-        axis2_dep_engine_undeploy(ws_info_list->deployer, env);
-    }
-    */
 
     return axis2_dep_engine_do_deploy(ws_info_list->deployer, env);
 }

Modified: webservices/axis2/trunk/c/src/core/engine/engine.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/engine/engine.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/engine/engine.c (original)
+++ webservices/axis2/trunk/c/src/core/engine/engine.c Tue Apr 24 23:02:46 2007
@@ -532,16 +532,7 @@
                 axiom_soap_envelope_create_default_soap_envelope(env, AXIOM_SOAP12);
         }
 
-        if (envelope)
-        {
-            /*axiom_soap_body_t *body = AXIOM_SOAP_ENVELOPE_GET_BODY(envelope, env); */
-            /* if (body) */
-            /*{ */
-               /*  axiom_soap_fault_t *fault = AXIOM_SOAP_BODY_GET_FAULT(body, env); */
-                /* TODO: fault processing method */
-            /*} */
-        }
-        else
+        if (!envelope)
         {
             return NULL;
         }

Modified: webservices/axis2/trunk/c/src/core/engine/soap_action_disp.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/engine/soap_action_disp.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/engine/soap_action_disp.c (original)
+++ webservices/axis2/trunk/c/src/core/engine/soap_action_disp.c Tue Apr 24 23:02:46 2007
@@ -85,7 +85,7 @@
         const axutil_env_t *env)
 {
     AXIS2_LOG_DEBUG(env->log, 
-         AXIS2_LOG_SI, "Checking for service using SOAPAction is a TODO item");
+         AXIS2_LOG_SI, "Checking for service using SOAPAction is not implemented");
     return NULL;
 }
 

Modified: webservices/axis2/trunk/c/src/core/phaseresolver/phase_resolver.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/phaseresolver/phase_resolver.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/phaseresolver/phase_resolver.c (original)
+++ webservices/axis2/trunk/c/src/core/phaseresolver/phase_resolver.c Tue Apr 24 23:02:46
2007
@@ -114,7 +114,7 @@
     phase_resolver->axis2_config = axis2_config;
 
     phase_resolver->svc = svc;
-    AXIS2_LOG_DEBUG(env->log, AXIS2_LOG_SI, "svc name is:%s",
+    AXIS2_LOG_DEBUG(env->log, AXIS2_LOG_SI, "Service name is : %s",
         axis2_svc_get_name(phase_resolver->svc, env));
 
     return phase_resolver;
@@ -363,7 +363,6 @@
                 phase_name = axis2_phase_rule_get_name(phase_rule, env);
             }
 
-            /* TODO change this in proper way */
             if (!phase_name || (0 == axutil_strcmp(phase_name, "")))
             {
                 AXIS2_ERROR_SET(env->error, AXIS2_ERROR_PHASE_IS_NOT_SPECIFED,
@@ -951,7 +950,7 @@
 
         axutil_hash_this(index_i, NULL, NULL, &v);
         op_desc = (axis2_op_t *) v;
-        AXIS2_LOG_DEBUG(env->log, AXIS2_LOG_SI, "op name is:%s",
+        AXIS2_LOG_DEBUG(env->log, AXIS2_LOG_SI, "Operation name is : %s",
             axutil_qname_get_localpart(axis2_op_get_qname(op_desc, env), env));
         modules = axis2_op_get_all_modules(op_desc, env);
         module_desc_qname = axis2_module_desc_get_qname(module_desc, env);

Modified: webservices/axis2/trunk/c/src/core/transport/http/common/http_response_writer.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/transport/http/common/http_response_writer.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/transport/http/common/http_response_writer.c (original)
+++ webservices/axis2/trunk/c/src/core/transport/http/common/http_response_writer.c Tue Apr
24 23:02:46 2007
@@ -103,9 +103,6 @@
     const axutil_env_t *env)
 {
     AXIS2_ENV_CHECK(env, AXIS2_FAILURE);
-    /*
-        TODO if bufferring is added flush the buffer
-    */
     return AXIS2_FALSE;
 }
 
@@ -153,9 +150,6 @@
     {
         return AXIS2_FAILURE;
     }
-    /*
-         TODO handle offset
-     */
     return AXIS2_SUCCESS;
 }
 

Modified: webservices/axis2/trunk/c/src/core/transport/http/common/http_simple_request.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/transport/http/common/http_simple_request.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/transport/http/common/http_simple_request.c (original)
+++ webservices/axis2/trunk/c/src/core/transport/http/common/http_simple_request.c Tue Apr
24 23:02:46 2007
@@ -405,9 +405,6 @@
         tmp_buf = tmp_buf3;
 
     }
-    /*
-        TODO :STREAM_READ => STREAM_READ_BYTES
-    */
     if (tmp_buf)
     {
         *buf = tmp_buf;

Modified: webservices/axis2/trunk/c/src/core/transport/http/common/http_worker.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/transport/http/common/http_worker.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/transport/http/common/http_worker.c (original)
+++ webservices/axis2/trunk/c/src/core/transport/http/common/http_worker.c Tue Apr 24 23:02:46
2007
@@ -532,9 +532,6 @@
 
     config =  axis2_conf_ctx_get_conf(conf_ctx, env);
 
-    /*
-        TODO implement the method
-    */
     return AXIS2_SUCCESS;
 }
 

Modified: webservices/axis2/trunk/c/src/core/transport/http/receiver/http_svr_thread.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/transport/http/receiver/http_svr_thread.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/transport/http/receiver/http_svr_thread.c (original)
+++ webservices/axis2/trunk/c/src/core/transport/http/receiver/http_svr_thread.c Tue Apr 24
23:02:46 2007
@@ -181,7 +181,6 @@
         axutil_network_handler_close_socket(env, svr_thread->listen_socket);
         svr_thread->listen_socket = -1;
     }
-    /* TODO: stop all the child threads */
     return AXIS2_SUCCESS;
 }
 

Modified: webservices/axis2/trunk/c/src/core/transport/http/sender/http_sender.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/transport/http/sender/http_sender.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/transport/http/sender/http_sender.c (original)
+++ webservices/axis2/trunk/c/src/core/transport/http/sender/http_sender.c Tue Apr 24 23:02:46
2007
@@ -617,9 +617,6 @@
     AXIS2_PARAM_CHECK(env->error, msg_ctx, AXIS2_FAILURE);
     AXIS2_PARAM_CHECK(env->error, response, AXIS2_FAILURE);
 
-    /*
-     * TODO MTOM support (MIME header)
-     */
     headers = axis2_http_simple_response_get_headers(response, env);
     if (headers == NULL)
     {
@@ -637,16 +634,6 @@
 															  , env), AXIS2_HTTP_HEADER_TRANSFER_ENCODING_CHUNKED))
             {
                 axis2_char_t *transfer_encoding = NULL;
-/*                transfer_encoding = */
-/*                     axutil_strdup(AXIS2_HTTP_HEADER_TRANSFER_ENCODING_CHUNKED, */
-/* 								 env); */
-/*                 property = axutil_property_create(env); */
-/*                 axutil_property_set_scope(property, env, AXIS2_SCOPE_REQUEST); */
-/*                 axutil_property_set_value(property, env, transfer_encoding); */
-/*                  axis2_msg_ctx_set_property(msg_ctx, env, */
-/* 										   AXIS2_HTTP_HEADER_TRANSFER_ENCODING, */
-/* 										   property); */
-/*                 response_chunked = AXIS2_TRUE; */
                 transfer_encoding =
                     axutil_strdup(env,
 					    AXIS2_HTTP_HEADER_TRANSFER_ENCODING_CHUNKED);

Modified: webservices/axis2/trunk/c/src/core/transport/http/sender/http_transport_sender.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/transport/http/sender/http_transport_sender.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/transport/http/sender/http_transport_sender.c (original)
+++ webservices/axis2/trunk/c/src/core/transport/http/sender/http_transport_sender.c Tue Apr
24 23:02:46 2007
@@ -390,9 +390,6 @@
             epr = NULL;
         }
     }
-    /*
-     * TODO handle errors
-     */
     return AXIS2_SUCCESS;
 }
 

Modified: webservices/axis2/trunk/c/src/core/transport/http/sender/ssl/ssl_stream.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/transport/http/sender/ssl/ssl_stream.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/transport/http/sender/ssl/ssl_stream.c (original)
+++ webservices/axis2/trunk/c/src/core/transport/http/sender/ssl/ssl_stream.c Tue Apr 24 23:02:46
2007
@@ -244,7 +244,6 @@
     int ret = -1;
     AXIS2_ENV_CHECK(env, AXIS2_CRITICAL_FAILURE);
 
-    /* TODO implement this */
     return ret;
 }
 

Modified: webservices/axis2/trunk/c/src/core/transport/http/sender/ssl/ssl_utils.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/transport/http/sender/ssl/ssl_utils.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/transport/http/sender/ssl/ssl_utils.c (original)
+++ webservices/axis2/trunk/c/src/core/transport/http/sender/ssl/ssl_utils.c Tue Apr 24 23:02:46
2007
@@ -39,8 +39,7 @@
 {
     SSL_METHOD *meth = NULL;
     SSL_CTX *ctx = NULL;
-    axis2_char_t *ca_file = server_cert; /*TODO: remove ca_file*/
-    /*axis2_char_t *key_file = NULL;*/
+    axis2_char_t *ca_file = server_cert; 
 
     AXIS2_ENV_CHECK(env, NULL);
 
@@ -67,7 +66,6 @@
 
     /* Load our keys and certificates
      * If we need client certificates it has to be done here
-     * TODO 
      */
     if (key_file) /*can we check if the server needs client auth?*/
     {

Modified: webservices/axis2/trunk/c/src/core/transport/http/server/apache2/apache2_stream.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/transport/http/server/apache2/apache2_stream.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/transport/http/server/apache2/apache2_stream.c (original)
+++ webservices/axis2/trunk/c/src/core/transport/http/server/apache2/apache2_stream.c Tue
Apr 24 23:02:46 2007
@@ -156,7 +156,6 @@
     int ret = -1;
     AXIS2_ENV_CHECK(env, AXIS2_CRITICAL_FAILURE);
 
-    /* TODO implement this */
     return ret;
 }
 

Modified: webservices/axis2/trunk/c/src/core/transport/http/util/http_transport_utils.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/core/transport/http/util/http_transport_utils.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/core/transport/http/util/http_transport_utils.c (original)
+++ webservices/axis2/trunk/c/src/core/transport/http/util/http_transport_utils.c Tue Apr
24 23:02:46 2007
@@ -420,7 +420,6 @@
         if (rest_param && 0 == axutil_strcmp(AXIS2_VALUE_TRUE,
                 axutil_param_get_value(rest_param, env)))
         {
-            /* TODO we have to check for NULLs */
             axiom_soap_body_t *def_body = NULL;
             axiom_document_t *om_doc = NULL;
             axiom_node_t *root_node = NULL;
@@ -579,9 +578,6 @@
     axutil_stream_t *in_stream,
     axis2_char_t *content_type)
 {
-    /*
-         TODO implement when MTOM support is added
-     */
     return NULL;
 }
 
@@ -590,9 +586,6 @@
     const axutil_env_t *env,
     axiom_element_t *om_element)
 {
-    /*
-         TODO implement when MTOM support is added
-     */
     return AXIS2_FALSE;
 }
 
@@ -601,28 +594,10 @@
     const axutil_env_t *env,
     axis2_msg_ctx_t *msg_ctx)
 {
-    /*axutil_property_t *property = NULL;
-    axutil_param_t *param = NULL;
-    axis2_char_t *value = NULL;*/
     AXIS2_ENV_CHECK(env, AXIS2_FAILURE);
     AXIS2_PARAM_CHECK(env->error, msg_ctx, AXIS2_FAILURE);
 
     return (axis2_msg_ctx_get_doing_mtom(msg_ctx, env));
-
-    /*param =  axis2_msg_ctx_get_parameter(msg_ctx, env, AXIS2_ENABLE_MTOM);
-    if (param)
-        value = axutil_param_get_value(param, env);
-
-    property =  axis2_msg_ctx_get_property(msg_ctx, env,
-            AXIS2_ENABLE_MTOM);
-    if (property)
-        value = (axis2_char_t *)axutil_property_get_value(property, env);
-
-    if (value)
-    {
-        return (axutil_strcmp(value, AXIS2_VALUE_TRUE) == 0);
-    }
-    return AXIS2_FALSE;*/
 }
 
 
@@ -631,9 +606,6 @@
     const axutil_env_t *env,
     axis2_msg_ctx_t *msg_ctx)
 {
-    /*
-        TODO implement when REST support is added
-    */
     return AXIS2_FALSE;
 }
 
@@ -643,9 +615,6 @@
     const axutil_env_t *env,
     axis2_msg_ctx_t *msg_ctx)
 {
-    /*
-        TODO implement when REST support is added
-    */
     return AXIS2_FALSE;
 }
 

Modified: webservices/axis2/trunk/c/src/modules/mod_addr/addr_in_handler.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/modules/mod_addr/addr_in_handler.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/modules/mod_addr/addr_in_handler.c (original)
+++ webservices/axis2/trunk/c/src/modules/mod_addr/addr_in_handler.c Tue Apr 24 23:02:46 2007
@@ -225,7 +225,6 @@
                     axis2_svc_grp_ctx_t *svc_ctx_grp_ctx =  axis2_conf_ctx_get_svc_grp_ctx(conf_ctx,
env, grp_id);
                     if (!svc_ctx_grp_ctx)
                     {
-                        /** TODO, set error */
                         return AXIS2_FAILURE;
                     }
                      axis2_msg_ctx_set_svc_grp_ctx_id(msg_ctx, env, svc_grp_ctx_id_str);
@@ -236,7 +235,6 @@
         }
         axutil_qname_free(qname, env);
     }
-    /** TODO, set error */
     return AXIS2_FAILURE;
 }
 

Modified: webservices/axis2/trunk/c/src/modules/mod_addr/mod_addr.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/src/modules/mod_addr/mod_addr.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/src/modules/mod_addr/mod_addr.c (original)
+++ webservices/axis2/trunk/c/src/modules/mod_addr/mod_addr.c Tue Apr 24 23:02:46 2007
@@ -68,9 +68,6 @@
 {
     if (module->handler_create_func_map)
     {
-        /* TODO
-         *  do the neccessary clean in hash map
-         */
         axutil_hash_free(module->handler_create_func_map, env);
         module->handler_create_func_map = NULL;
     }

Modified: webservices/axis2/trunk/c/util/src/platforms/windows/thread_mutex_windows.c
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/c/util/src/platforms/windows/thread_mutex_windows.c?view=diff&rev=532209&r1=532208&r2=532209
==============================================================================
--- webservices/axis2/trunk/c/util/src/platforms/windows/thread_mutex_windows.c (original)
+++ webservices/axis2/trunk/c/util/src/platforms/windows/thread_mutex_windows.c Tue Apr 24
23:02:46 2007
@@ -63,7 +63,7 @@
     }
     else
     {
-        /*TODO:support critical_section and nested_mutex*/
+        /* TODO :support critical_section and nested_mutex*/
     }
 
     return mutex;
@@ -94,7 +94,7 @@
 
     if (mutex->type == thread_mutex_critical_section)
     {
-        /*TODO:implement trylock for critical section*/
+        /* TODO :implement trylock for critical section*/
     }
     else
     {



---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org


Mime
View raw message