Return-Path: Delivered-To: apmail-ws-axis-dev-archive@www.apache.org Received: (qmail 23559 invoked from network); 22 Mar 2007 06:30:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 22 Mar 2007 06:30:26 -0000 Received: (qmail 1379 invoked by uid 500); 22 Mar 2007 06:30:30 -0000 Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org Received: (qmail 1331 invoked by uid 500); 22 Mar 2007 06:30:30 -0000 Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@ws.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list axis-dev@ws.apache.org Received: (qmail 1320 invoked by uid 99); 22 Mar 2007 06:30:30 -0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2007 23:30:30 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 32B9D714042 for ; Wed, 21 Mar 2007 23:29:32 -0700 (PDT) Message-ID: <29241973.1174544972180.JavaMail.jira@brutus> Date: Wed, 21 Mar 2007 23:29:32 -0700 (PDT) From: "Thilina Gunarathne (JIRA)" To: axis-dev@ws.apache.org Subject: [jira] Commented: (AXIS2-2358) Code level Comments In-Reply-To: <23423262.1174460852844.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/AXIS2-2358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483031 ] Thilina Gunarathne commented on AXIS2-2358: ------------------------------------------- >- // If the axisService is not null we get the binding that the request came to add >- // add it as a property to the messageContext >+ // If the axisService is not null, the binding that the request came to add is obtained. >+ // Add endpoints as a property to the messageContext At least the above change does not look right to me.. The current version in the source code which is given below looks better than that to me... // If the axisService is not null we get the binding that the request came to and // add it as a property to the messageContext > Code level Comments > ------------------- > > Key: AXIS2-2358 > URL: https://issues.apache.org/jira/browse/AXIS2-2358 > Project: Axis 2.0 (Axis2) > Issue Type: Improvement > Components: documentation > Affects Versions: 1.2 > Environment: Linux > Reporter: Karthiga Rajeevani Ratnam > Fix For: 1.2 > > Attachments: patch > > > Improvements made to inline code level comments on AddressingBasedDispatcher.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org For additional commands, e-mail: axis-dev-help@ws.apache.org