Return-Path: Delivered-To: apmail-ws-axis-dev-archive@www.apache.org Received: (qmail 67554 invoked from network); 6 Feb 2007 17:31:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Feb 2007 17:31:09 -0000 Received: (qmail 38357 invoked by uid 500); 6 Feb 2007 17:31:04 -0000 Delivered-To: apmail-ws-axis-dev-archive@ws.apache.org Received: (qmail 38322 invoked by uid 500); 6 Feb 2007 17:31:04 -0000 Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm Precedence: bulk Reply-To: axis-dev@ws.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list axis-dev@ws.apache.org Received: (qmail 38229 invoked by uid 99); 6 Feb 2007 17:31:03 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Feb 2007 09:31:03 -0800 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of rajith77@gmail.com designates 64.233.184.227 as permitted sender) Received: from [64.233.184.227] (HELO wr-out-0506.google.com) (64.233.184.227) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Feb 2007 09:30:53 -0800 Received: by wr-out-0506.google.com with SMTP id 67so1672129wri for ; Tue, 06 Feb 2007 09:30:32 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=NWRKqOaZwQaCdVUy8X3oZqaHqLsrWa0EhcSNylV2w5QdZWjIg3NzngnynPQsoX2HJQG7xaVe6y0r7yhmfVx+ljxrl4wYHdfApQQ7mqKSusBps4BMuzAt39ArOE2oqAihVbkOjefiSoUHFAPnHIq0rNoZKKrp+Dj1ES/mE7u8ZJw= Received: by 10.90.101.19 with SMTP id y19mr10780846agb.1170783032424; Tue, 06 Feb 2007 09:30:32 -0800 (PST) Received: by 10.90.120.9 with HTTP; Tue, 6 Feb 2007 09:30:32 -0800 (PST) Message-ID: Date: Tue, 6 Feb 2007 12:30:32 -0500 From: "Rajith Attapattu" To: axis-dev@ws.apache.org Subject: Re: [Axis2] Adding ClusterManager code the the codebase In-Reply-To: <1170778354.25174.122.camel@scylla.watson.ibm.com> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_8724_28744080.1170783032360" References: <9d4ec10b0702010946q13843d0q818e6e14ffcec62e@mail.gmail.com> <1170772060.25174.118.camel@scylla.watson.ibm.com> <19e0530f0702060631s66942811v1a2670d35f766f50@mail.gmail.com> <9d4ec10b0702060716h2e62e230h57efb1fc389b57fe@mail.gmail.com> <19e0530f0702060720m4b064877i7121cc59a0eb0199@mail.gmail.com> <9d4ec10b0702060802m59b9a144wedef6d5c52980fe7@mail.gmail.com> <1170778354.25174.122.camel@scylla.watson.ibm.com> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_8724_28744080.1170783032360 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline OK Bill, not so fast :) I don't call the ClusterManager for every property Change. I have a slightly modified interface, not the one chamikara provided. I only replicate at the end of an invocation. So here are the no of calls per invocation. if first request, 3 calls. One for Service Group ctx creation, one for service ctx creation, one for stateUpdate. for subsequent invocations only one call. State update. Now thats not bad. I don't think just 3 NOP's at the max and 1 NOP at the minimum is that much of a performance impact :) Regards, Rajith Attapattu Red Hat. On 2/6/07, Bill Nagy wrote: > > That's what I inferred from the interface -- any time there is a context > change or a property change, you want your interface to be invoked. > That's an awful lot of method invocations (even if they're no-ops) for > something arguably not core to a web services runtime. > > -Bill > > On Tue, 2007-02-06 at 21:32 +0530, Chamikara Jayalath wrote: > > Hi Dims, > > > > As this is still is its design stage final approach hs not been > > decided. The current code is available in a branch so no affect on the > > performance of the trunk. > > > > A method of the ClusterManager instance hs to be called in events such > > as Context creation and removal. Currently these directly get called > > from respective places of the context classes (should happen only if a > > ClusterManager hs been set i.e. when clustering is enabled). > > > > Chamikara > > > > > > On 2/6/07, Davanum Srinivas wrote: > > Chamikara, > > > > New notifications? like what we have already for > > services/modules? > > > > -- dims > > > > On 2/6/07, Chamikara Jayalath wrote: > > > Hi Bill, Dims, > > > > > > The ClusterManager impl will be initiated with the > > ConfigContext. This will > > > be called in places like Context Creation and removal and > > may be property > > > updates (hvnt fully decided yet). When Clustering is not > > present the cost > > > should be reduced to a null check. > > > > > > Chamikara > > > > > > > > > > > > > > > On 2/6/07, Davanum Srinivas wrote: > > > > Bill, > > > > > > > > from what i understand, it's in a separate maven module. > > Not in > > > > kernel. So you can ignore it :) > > > > > > > > -- dims > > > > > > > > On 2/6/07, Bill Nagy < nagy@watson.ibm.com > wrote: > > > > > What is the cost of this going to be for someone who > > doesn't want > > > > > clustering/this particular approach to clustering? I > > can't infer much > > > > > from the interface -- exactly which respective events > > are you referring > > > > > to? > > > > > > > > > > -Bill > > > > > > > > > > > > > > > On Thu, 2007-02-01 at 23:16 +0530, Chamikara Jayalath > > wrote: > > > > > > At initiation Axis2 will load a ClusterManager > > implementation object > > > > > > (if configured) and will call the methods of it > > whenever respective > > > > > > events occur. > > > > > > > > > > > > Chamikara > > > > > > > > > > > > > > > > > > [1] ClusterManager interface > > > > > > > > > > > > public abstract class ClusterManager { > > > > > > > > > > > > public abstract void init (ConfigurationContext > > context); > > > > > > public abstract void addContext (AbstractContext > > context); > > > > > > public abstract void removeContext > > (AbstractContext context); > > > > > > public abstract void addProperty (AbstractContext > > context, String > > > > > > propertyName, Object propertyValue); > > > > > > public abstract void removeProperty > > (AbstractContext context, > > > > > > String propertyName); > > > > > > public abstract void touchProperty > > (AbstractContext context, > > > > > > String propertyName); > > > > > > public abstract void commit (); > > > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: > > > axis-dev-unsubscribe@ws.apache.org > > > > > For additional commands, e-mail: > > axis-dev-help@ws.apache.org > > > > > > > > > > > > > > > > > > > > > > -- > > > > Davanum Srinivas :: http://wso2.org/:: Oxygen for Web > > Services Developers > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > To unsubscribe, e-mail: > > > axis-dev-unsubscribe@ws.apache.org > > > > For additional commands, e-mail: > > axis-dev-help@ws.apache.org > > > > > > > > > > > > > > > > > > > > -- > > Davanum Srinivas :: http://wso2.org/ :: Oxygen for Web > > Services Developers > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org > > For additional commands, e-mail: axis-dev-help@ws.apache.org > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org > For additional commands, e-mail: axis-dev-help@ws.apache.org > > ------=_Part_8724_28744080.1170783032360 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline OK Bill, not so fast :)

I don't call the ClusterManager for every property Change.
I have a slightly modified interface, not the one chamikara provided.

I only replicate at the end of an invocation.
So here are the no of calls per invocation.

if first request, 3 calls.
One for Service Group ctx creation, one for service ctx creation, one for stateUpdate.

for subsequent invocations
only one call. State update.

Now thats not bad.
I don't think just 3 NOP's at the max and 1 NOP at the minimum is that much of a performance impact :)

Regards,

Rajith Attapattu
Red Hat.

On 2/6/07, Bill Nagy <nagy@watson.ibm.com> wrote:
That's what I inferred from the interface -- any time there is a context
change or a property change, you want your interface to be invoked.
That's an awful lot of method invocations (even if they're no-ops) for
something arguably not core to a web services runtime.

-Bill

On Tue, 2007-02-06 at 21:32 +0530, Chamikara Jayalath wrote:
> Hi Dims,
>
> As this is still is its design stage final approach hs not been
> decided. The current code is available in a branch so no affect on the
> performance of the trunk.
>
> A method of the ClusterManager instance hs to be called in events such
> as Context creation and removal. Currently these directly get called
> from respective places of the context classes (should happen only if a
> ClusterManager hs been set i.e. when clustering is enabled).
>
> Chamikara
>
>
> On 2/6/07, Davanum Srinivas < davanum@gmail.com> wrote:
>         Chamikara,
>
>         New notifications? like what we have already for
>         services/modules?
>
>         -- dims
>
>         On 2/6/07, Chamikara Jayalath <chamikaramj@gmail.com> wrote:
>         > Hi Bill, Dims,
>         >
>         > The ClusterManager impl will be initiated with the
>         ConfigContext. This will
>         > be called in places like Context Creation and removal and
>         may be property
>         > updates (hvnt fully decided yet). When Clustering is not
>         present the cost
>         > should be reduced to a null check.
>         >
>         > Chamikara
>         >
>         >
>         >
>         >
>         > On 2/6/07, Davanum Srinivas <davanum@gmail.com> wrote:
>         > > Bill,
>         > >
>         > > from what i understand, it's in a separate maven module.
>         Not in
>         > > kernel. So you can ignore it :)
>         > >
>         > > -- dims
>         > >
>         > > On 2/6/07, Bill Nagy < nagy@watson.ibm.com > wrote:
>         > > > What is the cost of this going to be for someone who
>         doesn't want
>         > > > clustering/this particular approach to clustering?  I
>         can't infer much
>         > > > from the interface -- exactly which respective events
>         are you referring
>         > > > to?
>         > > >
>         > > > -Bill
>         > > >
>         > > >
>         > > > On Thu, 2007-02-01 at 23:16 +0530, Chamikara Jayalath
>         wrote:
>         > > > > At initiation Axis2 will load a ClusterManager
>         implementation object
>         > > > > (if configured) and will call the methods of it
>         whenever respective
>         > > > > events occur.
>         > > > >
>         > > > > Chamikara
>         > > > >
>         > > > >
>         > > > > [1] ClusterManager interface
>         > > > >
>         > > > > public abstract class ClusterManager {
>         > > > >
>         > > > >     public abstract void init (ConfigurationContext
>         context);
>         > > > >     public abstract void addContext (AbstractContext
>         context);
>         > > > >     public abstract void removeContext
>         (AbstractContext context);
>         > > > >     public abstract void addProperty (AbstractContext
>         context, String
>         > > > > propertyName, Object  propertyValue);
>         > > > >     public abstract void removeProperty
>         (AbstractContext context,
>         > > > > String propertyName);
>         > > > >     public abstract void touchProperty
>         (AbstractContext context,
>         > > > > String propertyName);
>         > > > >     public abstract void commit ();
>         > > > >
>         > > > > }
>         > > > >
>         > > >
>         > > >
>         > > >
>         >
>         ---------------------------------------------------------------------
>         > > > To unsubscribe, e-mail:
>         > axis-dev-unsubscribe@ws.apache.org
>         > > > For additional commands, e-mail:
>         axis-dev-help@ws.apache.org
>         > > >
>         > > >
>         > >
>         > >
>         > > --
>         > > Davanum Srinivas :: http://wso2.org/:: Oxygen for Web
>         Services Developers
>         > >
>         > >
>         >
>         ---------------------------------------------------------------------
>         > > To unsubscribe, e-mail:
>         > axis-dev-unsubscribe@ws.apache.org
>         > > For additional commands, e-mail:
>         axis-dev-help@ws.apache.org
>         > >
>         > >
>         >
>         >
>
>
>         --
>         Davanum Srinivas :: http://wso2.org/ :: Oxygen for Web
>         Services Developers
>
>         ---------------------------------------------------------------------
>         To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
>         For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


------=_Part_8724_28744080.1170783032360--