Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: axis-dev@ws.apache.org
Received-SPF: pass (herse.apache.org: domain of chamikaramj@gmail.com
 designates 66.249.92.175 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=mviTDenQkGL02HFIMIr651RRYVT99+rRz4QJkPs2R+zEGWNLOhWaJSJYx2oDwh8Pdetsk4YjYIKxhNHbGadZXA0cKwmS2zY6w47gHjCfgNPkyFuad7H+phVw9XghzXT3mght6PvkuAEHmenc24H6s60x1sUoCJjCfoIf3qvE4DQ=
Message-ID: <9d4ec10b0701282315m5b578675ke61ae76a6a529df0@mail.gmail.com>
Date: Mon, 29 Jan 2007 12:45:11 +0530
From: "Chamikara Jayalath" <chamikaramj@gmail.com>
To: axis-dev@ws.apache.org
Subject: Re: [Axis2] Issues with the current code base
In-Reply-To: <45BD9023.4050008@opensource.lk>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_80156_4404745.1170054911207"
References: <45BD9023.4050008@opensource.lk>

------=_Part_80156_4404745.1170054911207
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

On 1/29/07, Deepal Jayasinghe <deepal@opensource.lk> wrote:
>
> Hi all;
>
> I just went though the current code base and realized that
> MessageContext code has been changed a lot . I found few issues with the
> code base and hope we need to fix them. So I thought of sending this
> mail for everyone's consideration.
>
> Well someone please explain to me whose going to need MessageContext
> serialization ,
> Chamikara : Do you want that for Sandesha ?


Currently no. But Matt had mentioned that he is working on something that
uses this.
Matt ?

Ruchith : Do you want that for Security ?
>
> If none of you want this , who else need this ?
> I am asking this question b'coz introduction of MC serialization we have
> the following for each req.
> - When ever Axis2 received a message it calls
> activateMessageContext(msgContext);
> - And what that does is , it calls mc.activate(engineContext); method
>
> Unfortunately that method is TOO long and was very difficult to
> understand :). Ann can you simplify the method (that will be very helpful)
> .
>
> In the meantime code convention in MC has changed a lot and need to have
> very consistent code convention, please do not differ form that.
>
> Among the all , the most worst thing I saw in the code is following kind
> of things, I strongly believe we should not have this kind of code in
> the code base, If you found such kind of code please point out them then
> and there.
>
> - String tmpClassNameStr = "null";   (is this the way we initialize to
> NULL )
> - String tmpHasList      = "no list"
> - Unnecessary casting
> - A number of unused variables
> - Variable declarations here and there  (as an example private static
> final String  - selfManagedDataDelimiter = "*";)
>
> In addition to that someone has added code to change OutInAxisOperation
> name in the client side temporally, can I know why  ?
>
> So please comment your ideas on this.
>
> Thanks
> Deepal
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: axis-dev-help@ws.apache.org
>
>

------=_Part_80156_4404745.1170054911207
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

<br><br><div><span class="gmail_quote">On 1/29/07, <b class="gmail_sendername">Deepal Jayasinghe</b> &lt;<a href="mailto:deepal@opensource.lk">deepal@opensource.lk</a>&gt; wrote:</span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi all;<br><br>I just went though the current code base and realized that<br>MessageContext code has been changed a lot . I found few issues with the<br>code base and hope we need to fix them. So I thought of sending this
<br>mail for everyone&#39;s consideration.<br><br>Well someone please explain to me whose going to need MessageContext<br>serialization ,<br> Chamikara : Do you want that for Sandesha ?</blockquote><div><br>Currently no. But Matt had mentioned that he is working on something that uses this.
<br>Matt ?<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> Ruchith : Do you want that for Security ?<br><br>If none of you want this , who else need this ?
<br>I am asking this question b&#39;coz introduction of MC serialization we have<br>the following for each req.<br> - When ever Axis2 received a message it calls<br>activateMessageContext(msgContext);<br> - And what that does is , it calls 
mc.activate(engineContext); method<br><br>Unfortunately that method is TOO long and was very difficult to<br>understand :). Ann can you simplify the method (that will be very helpful) .<br><br>In the meantime code convention in MC has changed a lot and need to have
<br>very consistent code convention, please do not differ form that.<br><br>Among the all , the most worst thing I saw in the code is following kind<br>of things, I strongly believe we should not have this kind of code in
<br>the code base, If you found such kind of code please point out them then<br>and there.<br><br> - String tmpClassNameStr = &quot;null&quot;;&nbsp;&nbsp; (is this the way we initialize to<br>NULL )<br> - String tmpHasList&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;= &quot;no list&quot;
<br> - Unnecessary casting<br> - A number of unused variables<br> - Variable declarations here and there&nbsp;&nbsp;(as an example private static<br>final String&nbsp;&nbsp;- selfManagedDataDelimiter = &quot;*&quot;;)<br><br>In addition to that someone has added code to change OutInAxisOperation
<br>name in the client side temporally, can I know why&nbsp;&nbsp;?<br><br>So please comment your ideas on this.<br><br>Thanks<br>Deepal<br><br><br><br>---------------------------------------------------------------------<br>To unsubscribe, e-mail: 
<a href="mailto:axis-dev-unsubscribe@ws.apache.org">axis-dev-unsubscribe@ws.apache.org</a><br>For additional commands, e-mail: <a href="mailto:axis-dev-help@ws.apache.org">axis-dev-help@ws.apache.org</a><br><br></blockquote>
</div><br>

------=_Part_80156_4404745.1170054911207--