Mailing-List: contact axis-dev-help@ws.apache.org; run by ezmlm
Precedence: bulk
Reply-To: axis-dev@ws.apache.org
Received-SPF: neutral (herse.apache.org: local policy)
Message-ID: <45BD9023.4050008@opensource.lk>
Date: Mon, 29 Jan 2007 11:41:47 +0530
From: Deepal Jayasinghe <deepal@opensource.lk>
User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
MIME-Version: 1.0
To: "axis-dev@ws.apache.org" <axis-dev@ws.apache.org>
Subject: [Axis2] Issues with the current code base
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi all;

I just went though the current code base and realized that
MessageContext code has been changed a lot . I found few issues with the
code base and hope we need to fix them. So I thought of sending this
mail for everyone's consideration.

Well someone please explain to me whose going to need MessageContext
serialization ,
 Chamikara : Do you want that for Sandesha ?
 Ruchith : Do you want that for Security ?

If none of you want this , who else need this ?
I am asking this question b'coz introduction of MC serialization we have
the following for each req.
 - When ever Axis2 received a message it calls 
activateMessageContext(msgContext);
 - And what that does is , it calls mc.activate(engineContext); method

Unfortunately that method is TOO long and was very difficult to
understand :). Ann can you simplify the method (that will be very helpful) .
 
In the meantime code convention in MC has changed a lot and need to have
very consistent code convention, please do not differ form that. 

Among the all , the most worst thing I saw in the code is following kind
of things, I strongly believe we should not have this kind of code in
the code base, If you found such kind of code please point out them then
and there.

 - String tmpClassNameStr = "null";   (is this the way we initialize to
NULL )
 - String tmpHasList      = "no list"
 - Unnecessary casting
 - A number of unused variables
 - Variable declarations here and there  (as an example private static
final String  - selfManagedDataDelimiter = "*";)

In addition to that someone has added code to change OutInAxisOperation
name in the client side temporally, can I know why  ?

So please comment your ideas on this.

Thanks
Deepal


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org