axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From barre...@apache.org
Subject svn commit: r501148 - /webservices/axis2/trunk/java/modules/metadata/src/org/apache/axis2/jaxws/description/impl/ServiceDescriptionImpl.java
Date Mon, 29 Jan 2007 19:15:31 GMT
Author: barrettj
Date: Mon Jan 29 11:15:30 2007
New Revision: 501148

URL: http://svn.apache.org/viewvc?view=rev&rev=501148
Log:
Enable validation errors for JAX-WS provider problem that were temporarily allowed

Modified:
    webservices/axis2/trunk/java/modules/metadata/src/org/apache/axis2/jaxws/description/impl/ServiceDescriptionImpl.java

Modified: webservices/axis2/trunk/java/modules/metadata/src/org/apache/axis2/jaxws/description/impl/ServiceDescriptionImpl.java
URL: http://svn.apache.org/viewvc/webservices/axis2/trunk/java/modules/metadata/src/org/apache/axis2/jaxws/description/impl/ServiceDescriptionImpl.java?view=diff&rev=501148&r1=501147&r2=501148
==============================================================================
--- webservices/axis2/trunk/java/modules/metadata/src/org/apache/axis2/jaxws/description/impl/ServiceDescriptionImpl.java
(original)
+++ webservices/axis2/trunk/java/modules/metadata/src/org/apache/axis2/jaxws/description/impl/ServiceDescriptionImpl.java
Mon Jan 29 11:15:30 2007
@@ -599,15 +599,8 @@
                 providerInterfaceValid = true;
                 //This is a provider based endpoint, make sure the annotation exists
                 if (composite.getWebServiceProviderAnnot() == null) {
-                    // TODO: (VALIDATION) Don't throw this yet because a LOT of provider
tests fail validation with it! 
-                    if (true) {
-                        log.error("FIXME: Validation error that is currently allowed: This
is a Provider based endpoint that does not contain a WebServiceProvider annotation.  Provider
class: " + composite.getClassName());
-                        log.debug("Failing composite: " + composite.toString());
-                    }
-                    else {
-                        // TODO: RAS/NLS
-                        throw ExceptionFactory.makeWebServiceException("Validation error:
This is a Provider based endpoint that does not contain a WebServiceProvider annotation. 
Provider class: " + composite.getClassName());
-                    }
+                    // TODO: RAS/NLS
+                    throw ExceptionFactory.makeWebServiceException("Validation error: This
is a Provider based endpoint that does not contain a WebServiceProvider annotation.  Provider
class: " + composite.getClassName());
                 }
             }
         }
@@ -687,17 +680,9 @@
 					//Verify that WebService annotation does not contain a name attribute
 					//(per JSR181 Sec. 3.1)
 					if (composite.getWebServiceAnnot().name() != null) {
-                        // TODO: (VALIDATION) Don't throw this yet because a LOT of provider
tests fail validation with it! 
-                        if (true) {
-                            log.error("FIXME: Validation error currently allowed: WebService.name
must not be specified when the bean specifies an endpoint interface.  Implentation class:
"  
-                                    + composite.getClassName() + "; WebService.name: " +
composite.getWebServiceAnnot().name());
-                            log.debug("Failing composite: " + composite.toString());
-                        }
-                        else {
-                            // TODO: RAS/NLS
-                            throw ExceptionFactory.makeWebServiceException("Validation error:
WebService.name must not be specified when the bean specifies an endpoint interface.  Implentation
class: "  
-                                    + composite.getClassName() + "; WebService.name: " +
composite.getWebServiceAnnot().name());
-                        }
+                        // TODO: RAS/NLS
+                        throw ExceptionFactory.makeWebServiceException("Validation error:
WebService.name must not be specified when the bean specifies an endpoint interface.  Implentation
class: "  
+                                + composite.getClassName() + "; WebService.name: " + composite.getWebServiceAnnot().name());
 					}
 					
                     validateSEI(seic);



---------------------------------------------------------------------
To unsubscribe, e-mail: axis-cvs-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-cvs-help@ws.apache.org


Mime
View raw message