axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan M. Feldstein" <afel...@earthlink.net>
Subject Re: [Axis2]Running build before commiting code
Date Fri, 03 Nov 2006 23:46:27 GMT
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
  <meta content="text/html;charset=UTF-8" http-equiv="Content-Type">
  <title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Eran Chinthaka wrote:
<blockquote cite="mid454AD302.9040309@opensource.lk" type="cite">
  <pre wrap="">If we exclude something from the tests, then no one will run it,
whatever you say. This is what happened to itests in integration folder.
I for one didn't run that for some time, did you?

So what I suggest is to keep the default behavior as is and if some one
knows what he is doing then he needs to put the flag , Ruchith put
,explicitly.

See, we can not afford to break anything at this moment. I encounter
couple of bugs which happens to happen again-and-again. I fixed it all
the time but some one breaks it again. The reason is lack of tests.
Every test in integration module or any other module makes sure
particular features are working properly.

I prefer adding more tests than removing it. Yes it is pain when you do
a build, but it is for the betterment of long term stability of Axis2.
Please use the proper flags sensibly.

  </pre>
</blockquote>
Eran is absolutely right.<br>
<br>
When I fixed some bugs in UnsignedLong, I was amazed to find that none
of the test cases covered the upper half of the number space! (I added
one.) Those are the bit patterns that a primitive long would consider
to be negative, but an UnsignedLong would be required to interpret as
large positive numbers. In other words, the most important test cases
for the UnsignedLong class were missing.<br>
<br>
If this is representative of test coverage in Axis2, then we have a
problem. If anything, more testing is required.<br>
<br>
<div class="moz-signature">-- <br>
<meta name="generator"
 content="HTML Tidy for Solaris (vers 1st March 2004), see www.w3.org">
<title>Alan M. Feldstein</title>
<p>Alan Feldstein</p>
<img src="cid:part1.09050708.02010708@earthlink.net"
 alt="Cosmic Horizon logo" height="55" width="101">
<p><a href="http://www.alanfeldstein.com/">http://www.alanfeldstein.com/</a></p>
</div>
</body>
</html>

Mime
View raw message