axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Davanum Srinivas (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (AXIS2-1246) Generated SOAP Action header is invalid
Date Sun, 01 Oct 2006 15:06:20 GMT
     [ http://issues.apache.org/jira/browse/AXIS2-1246?page=all ]

Davanum Srinivas resolved AXIS2-1246.
-------------------------------------

    Resolution: Fixed

Thanks Thomas. Fixed in latest SVN.

-- dims

> Generated SOAP Action header is invalid
> ---------------------------------------
>
>                 Key: AXIS2-1246
>                 URL: http://issues.apache.org/jira/browse/AXIS2-1246
>             Project: Apache Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.0
>         Environment: WinXP, JDK14
>            Reporter: Thomas Eckoldt
>
> According to the SOAP spec the SOAPAction http header is defined as
>     "SOAPAction" ":" [ <"> URI-reference <"> ]
> Example: 
>     SOAPAction: "customerAdd"
> The double quotes around the SOAPAction value are not generated by Axis2 in CommonsHTTPTransportSender:
> Around line 300:
>             if (soapActionString == null || JavaUtils.isTrueExplicitly(disableSoapAction))
{
>                 soapActionString = "\"\"";
>             } else if (soapActionString.startsWith("\"")) {  // SOAPAction string must
be a quoted string
>                 soapActionString = "\"" + soapActionString + "\"";
>             }
> This code does the following transformation:
> customerAdd   ->  customerAdd
> "customerAdd" -> ""customerAdd""
> This is obviously wrong. The second if statement should ask if soapActionString is *not*
starting with double quote and then adding the quotes.
> So the bugfix would look like:
>             if (soapActionString == null || JavaUtils.isTrueExplicitly(disableSoapAction))
{
>                 soapActionString = "\"\"";
>             } else if (!soapActionString.startsWith("\"")) {  // SOAPAction string must
be a quoted string
>                 soapActionString = "\"" + soapActionString + "\"";
>             }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Mime
View raw message