axis-java-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Davanum Srinivas" <dava...@gmail.com>
Subject Re: [Axis2] Re-setting of the Action
Date Thu, 31 Aug 2006 12:59:44 GMT
I think the general intent is to avoid cloning options at all costs.
And if the internal classes do not change the options, then the user
can reuse the options class. the change for the setAction("") broke
that unwritten contract is my guess.

thanks,
dims

On 8/31/06, Davanum Srinivas <davanum@gmail.com> wrote:
> David,
>
> I've tracked it down to this change from Deepal. Not sure if he remembers it :)
> http://svn.apache.org/viewvc?view=rev&revision=366507
>
> -- dims
>
> On 8/31/06, David Illsley <davidillsley@gmail.com> wrote:
> > So there are 2 ways of reusing the Options object.
> > 1. User re-use so that a user can sc.sendReceive() repeatedly and it works
> > 2. Internal re-use of the Options object for the response per
> > OutInAxisOperation line 349:
> >      // This is a hack - Needs to change
> >      responseMessageContext.setOptions(options);
> >
> > It is 2 which is preventing 1 from working and 2 that I'm looking for
> > someone to explain.
> > Hope that clarifies things a bit,
> > David
> >
> > On 31/08/06, Sanjiva Weerawarana <sanjiva@opensource.lk> wrote:
> > > On Tue, 2006-08-29 at 12:39 +0100, David Illsley wrote:
> > > > Hi Chamikara,
> > > > I don't know why the code is trying to reuse the request side Options
> > > > object, just that it is and that it is is marked in the code with:
> > > >  // This is a hack - Needs to change
> > > >
> > > > Which suggests that it's being done for a conscious reason but I can't
> > > > work out what it is. If someone can explain it I'll be more that happy
> > > > to try to do a better fix.
> > > >
> > > > Can anyone shed any light on this?
> > >
> > > I'm confused.. why would we not want to re-use the options?? It *must*
> > > be possible to use sc.sendReceive(..) followed by an immediate
> > > sc.sendReceive() and expect it to work.
> > >
> > > I guess I don't understand your comment in an earlier note on this
> > > thread:
> > >
> > > "> I added that because the Options object is reused so soapAction needs
> > > > to be removed so that soapAction+wsa:Action on response don't conflict
> > > > (because if they do the addressing in handler will fault)"
> > >
> > > Sanjiva.
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> > > For additional commands, e-mail: axis-dev-help@ws.apache.org
> > >
> > >
> >
> >
> > --
> > David Illsley - IBM Web Services Development
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
> > For additional commands, e-mail: axis-dev-help@ws.apache.org
> >
> >
>
>
> --
> Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers)
>


-- 
Davanum Srinivas : http://www.wso2.net (Oxygen for Web Service Developers)

---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


Mime
View raw message